Page MenuHomeFreeBSD
Differential D33166

Add an arm64 sha512 feature check
ClosedPublic
Actions

Authored by andrew on Nov 29 2021, 5:23 PM.
Tags
None
Referenced Files
F156916348: D33166.id99306.diff
Sun, May 17, 8:21 AM
F156904047: D33166.id99165.diff
Sun, May 17, 5:57 AM
F156859919: D33166.id.diff
Sat, May 16, 11:02 PM
Unknown Object (File)
Fri, May 8, 2:11 AM
Unknown Object (File)
Mon, May 4, 2:52 PM
Unknown Object (File)
Thu, Apr 30, 9:25 AM
Unknown Object (File)
Wed, Apr 29, 5:39 AM
Unknown Object (File)
Sat, Apr 25, 6:12 AM
View All Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
emaste
Commits
rGa72050a86fff: Add an arm64 sha512 feature check
rG629b5e87ed82: Add an arm64 sha512 feature check
Summary

This is only available in recent toolchains. Check for it so we can
use it in libmd.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43097
Build 39985: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 29 2021, 5:23 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptNov 29 2021, 5:23 PM
andrew requested review of this revision.Nov 29 2021, 5:23 PM
Harbormaster completed remote builds in B43027: Diff 99165.Nov 29 2021, 5:23 PM
emaste added inline comments.Nov 29 2021, 5:41 PM
share/mk/bsd.compiler.mk
259

If this is the case retpoline should be here too, but instead I think we could just drop this comment, list aarch64-sha512 in the list at line 22, and add a MD annotation there.

andrew updated this revision to Diff 99306.Dec 1 2021, 2:50 PM

Update based on feedback

Harbormaster completed remote builds in B43097: Diff 99306.Dec 1 2021, 2:50 PM
emaste accepted this revision.Dec 1 2021, 3:01 PM
This revision is now accepted and ready to land.Dec 1 2021, 3:01 PM
Closed by commit rG629b5e87ed82: Add an arm64 sha512 feature check (authored by andrew). · Explain WhyDec 1 2021, 3:15 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG629b5e87ed82: Add an arm64 sha512 feature check.
andrew added a commit: rGa72050a86fff: Add an arm64 sha512 feature check.Dec 20 2021, 2:02 PM

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines

Diff 99306

View Options

share/mk/bsd.compiler.mk

Loading...