Page MenuHomeFreeBSD
Differential D33218

fb: Remove unused FBIOGXINFO ioctl
ClosedPublic
Actions

Authored by manu on Dec 1 2021, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 10:58 AM
Unknown Object (File)
Thu, May 16, 9:28 AM
Unknown Object (File)
Thu, May 16, 9:27 AM
Unknown Object (File)
Tue, May 14, 6:23 AM
Unknown Object (File)
Feb 22 2024, 10:56 AM
Unknown Object (File)
Feb 22 2024, 10:56 AM
Unknown Object (File)
Feb 22 2024, 10:56 AM
Unknown Object (File)
Feb 21 2024, 11:53 PM
View All 31 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
emaste
imp
tsoome
Commits
rG0c543a654125: fb: Remove some unused ioctls
rG706f32db8aec: fb: Remove some unused ioctls
Summary

Commit 6d1699583d7e added the FBIOGXINFO ioctl and said that implementation
in driver will come later.
Since it was in 2001 I think we can remove this.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43092
Build 39980: arc lint + arc unit

Event Timeline

manu created this revision.Dec 1 2021, 2:23 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptDec 1 2021, 2:23 PM
manu requested review of this revision.Dec 1 2021, 2:23 PM
Harbormaster completed remote builds in B43092: Diff 99299.Dec 1 2021, 2:23 PM
manu added a parent revision: D33217: fb: Remove unused cursors ioctls.Dec 1 2021, 2:23 PM
manu added a child revision: D33219: fb: Remove unused FBIOMONINFO ioctl.
manu added reviewers: emaste, imp, tsoome.Dec 1 2021, 2:25 PM
emaste added a comment.Dec 1 2021, 3:30 PM

Merge with D33220? They both come from R10:6d1699583d7e. In fact, should that commit just be reverted?

emaste accepted this revision.Dec 1 2021, 3:30 PM
This revision is now accepted and ready to land.Dec 1 2021, 3:30 PM
emaste mentioned this in D33219: fb: Remove unused FBIOMONINFO ioctl.Dec 1 2021, 3:31 PM
imp accepted this revision.Dec 1 2021, 3:32 PM
tsoome accepted this revision.Dec 1 2021, 4:00 PM
manu added a comment.Dec 1 2021, 4:16 PM
In D33218#750760, @emaste wrote:

Merge with D33220? They both come from R10:6d1699583d7e. In fact, should that commit just be reverted?

I'll check if this commit can be reverted directly, if that's the case I'll do that and point to this rev.
If not I'm ok with merging the diffs.

Closed by commit rG706f32db8aec: fb: Remove some unused ioctls (authored by manu). · Explain WhyDec 6 2021, 10:31 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG706f32db8aec: fb: Remove some unused ioctls.
manu added a commit: rG0c543a654125: fb: Remove some unused ioctls.Dec 21 2021, 9:23 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
fb/
1 line
sys/
15 lines

Diff 99299

View Options

sys/dev/fb/fb.c

Loading...
View Options

sys/sys/fbio.h

Loading...