Page MenuHomeFreeBSD
Differential D33221

fb: Add new FBTYPE_EFIFB
ClosedPublic
Actions

Authored by manu on Dec 1 2021, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 4:04 AM
Unknown Object (File)
Thu, Jan 15, 9:48 PM
Unknown Object (File)
Thu, Jan 15, 8:17 PM
Unknown Object (File)
Thu, Jan 8, 4:31 AM
Unknown Object (File)
Mon, Jan 5, 10:29 PM
Unknown Object (File)
Wed, Dec 31, 8:33 AM
Unknown Object (File)
Tue, Dec 30, 9:13 PM
Unknown Object (File)
Dec 20 2025, 7:11 PM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
emaste
imp
tsoome
Commits
rG6bd6344f139f: fb: Add new FBTYPE_EFIFB
rGca23e9d2ac2c: fb: Add new FBTYPE_EFIFB
Summary

Currently the type isn't set in the fbtype struct so any userland
program that call the FBIOGTYPE ioctl will think it's a FBTYPE_SUN1BW
which is far from the truth.
No app that I found find checks the type but at least now it's correct.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Dec 1 2021, 2:23 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptDec 1 2021, 2:23 PM
manu requested review of this revision.Dec 1 2021, 2:23 PM
Harbormaster completed remote builds in B43095: Diff 99302.Dec 1 2021, 2:23 PM
manu added a parent revision: D33220: fb: Remove unused FBIOPUTCMAPI/FBIOGETCMAPI ioctls.Dec 1 2021, 2:23 PM
manu added reviewers: emaste, imp, tsoome.Dec 1 2021, 2:24 PM
emaste accepted this revision.Dec 1 2021, 2:26 PM
emaste added inline comments.
sys/sys/fbio.h
94–96

maybe a comment referencing EFI GOP?

This revision is now accepted and ready to land.Dec 1 2021, 2:26 PM
manu updated this revision to Diff 99303.Dec 1 2021, 2:28 PM

Add comment about GOP

This revision now requires review to proceed.Dec 1 2021, 2:28 PM
Harbormaster completed remote builds in B43096: Diff 99303.Dec 1 2021, 2:28 PM
manu marked an inline comment as done.Dec 1 2021, 2:28 PM
tsoome added a comment.Dec 1 2021, 2:29 PM

I'd guess the same issue is with VBE.

sys/sys/fbio.h
94–96

it can also be UGA (at least, on paper;)

emaste added a comment.Dec 1 2021, 2:29 PM

vt_vga.c, vbefb.c should get similar treatment

manu added inline comments.Dec 1 2021, 2:30 PM
sys/sys/fbio.h
94–96

Yeah on paper ;)
Good luck finding a UGA compatible firmware nowadays.

manu added a comment.Dec 1 2021, 2:30 PM
In D33221#750698, @tsoome wrote:

I'd guess the same issue is with VBE.

Yeah it's the same for all generic vt drivers.

emaste accepted this revision.Dec 1 2021, 2:30 PM
This revision is now accepted and ready to land.Dec 1 2021, 2:30 PM
tsoome accepted this revision.Dec 1 2021, 2:44 PM
imp accepted this revision.Dec 3 2021, 11:39 PM
Closed by commit rGca23e9d2ac2c: fb: Add new FBTYPE_EFIFB (authored by manu). · Explain WhyDec 6 2021, 10:31 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGca23e9d2ac2c: fb: Add new FBTYPE_EFIFB.
manu added a commit: rG6bd6344f139f: fb: Add new FBTYPE_EFIFB.Dec 21 2021, 9:23 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
hw/
efifb/
1 line
sys/
4 lines

Diff 99537

View Options

sys/dev/vt/hw/efifb/efifb.c

Loading...
View Options

sys/sys/fbio.h

Loading...