Page MenuHomeFreeBSD
Differential D33166

Add an arm64 sha512 feature check
ClosedPublic
Actions

Authored by andrew on Nov 29 2021, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 3:21 AM
Unknown Object (File)
Mon, Feb 24, 9:01 PM
Unknown Object (File)
Mon, Feb 24, 4:09 PM
Unknown Object (File)
Mon, Feb 24, 2:10 PM
Unknown Object (File)
Mon, Feb 24, 9:15 AM
Unknown Object (File)
Sun, Feb 23, 5:36 PM
Unknown Object (File)
Sun, Feb 23, 6:09 AM
Unknown Object (File)
Feb 16 2025, 2:40 PM
View All 75 Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
emaste
Commits
rGa72050a86fff: Add an arm64 sha512 feature check
rG629b5e87ed82: Add an arm64 sha512 feature check
Summary

This is only available in recent toolchains. Check for it so we can
use it in libmd.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43027
Build 39915: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 29 2021, 5:23 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptNov 29 2021, 5:23 PM
andrew requested review of this revision.Nov 29 2021, 5:23 PM
Harbormaster completed remote builds in B43027: Diff 99165.Nov 29 2021, 5:23 PM
emaste added inline comments.Nov 29 2021, 5:41 PM
share/mk/bsd.compiler.mk
258

If this is the case retpoline should be here too, but instead I think we could just drop this comment, list aarch64-sha512 in the list at line 22, and add a MD annotation there.

andrew updated this revision to Diff 99306.Dec 1 2021, 2:50 PM

Update based on feedback

Harbormaster completed remote builds in B43097: Diff 99306.Dec 1 2021, 2:50 PM
emaste accepted this revision.Dec 1 2021, 3:01 PM
This revision is now accepted and ready to land.Dec 1 2021, 3:01 PM
Closed by commit rG629b5e87ed82: Add an arm64 sha512 feature check (authored by andrew). · Explain WhyDec 1 2021, 3:15 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG629b5e87ed82: Add an arm64 sha512 feature check.
andrew added a commit: rGa72050a86fff: Add an arm64 sha512 feature check.Dec 20 2021, 2:02 PM

Revision Contents
Changeset List

PathSize
share/
mk/
9 lines

Diff 99165

View Options

share/mk/bsd.compiler.mk

Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines
static void vtcon_tty_free(void *); static void vtcon_tty_free(void *);
static void vtcon_get_console_size(struct vtcon_softc *, uint16_t *, static void vtcon_get_console_size(struct vtcon_softc *, uint16_t *,
uint16_t *); uint16_t *);
static void vtcon_enable_interrupts(struct vtcon_softc *); static void vtcon_enable_interrupts(struct vtcon_softc *);
static void vtcon_disable_interrupts(struct vtcon_softc *); static void vtcon_disable_interrupts(struct vtcon_softc *);
#define vtcon_modern(_sc) (((_sc)->vtcon_features & VIRTIO_F_VERSION_1) != 0)
#define vtcon_htog16(_sc, _val) virtio_htog16(vtcon_modern(_sc), _val)
#define vtcon_htog32(_sc, _val) virtio_htog32(vtcon_modern(_sc), _val)
#define vtcon_htog64(_sc, _val) virtio_htog64(vtcon_modern(_sc), _val)
#define vtcon_gtoh16(_sc, _val) virtio_gtoh16(vtcon_modern(_sc), _val)
#define vtcon_gtoh32(_sc, _val) virtio_gtoh32(vtcon_modern(_sc), _val)
#define vtcon_gtoh64(_sc, _val) virtio_gtoh64(vtcon_modern(_sc), _val)
static int vtcon_pending_free; static int vtcon_pending_free;
static struct ttydevsw vtcon_tty_class = { static struct ttydevsw vtcon_tty_class = {
.tsw_flags = 0, .tsw_flags = 0,
.tsw_open = vtcon_tty_open, .tsw_open = vtcon_tty_open,
.tsw_close = vtcon_tty_close, .tsw_close = vtcon_tty_close,
.tsw_outwakeup = vtcon_tty_outwakeup, .tsw_outwakeup = vtcon_tty_outwakeup,
.tsw_free = vtcon_tty_free, .tsw_free = vtcon_tty_free,
▲ Show 20 Lines • Show All 188 Lines • ▼ Show 20 Lines
{ {
device_t dev; device_t dev;
uint64_t features; uint64_t features;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
features = VTCON_FEATURES; features = VTCON_FEATURES;
sc->vtcon_features = virtio_negotiate_features(dev, features); sc->vtcon_features = virtio_negotiate_features(dev, features);
virtio_finalize_features(dev);
} }
static void static void
vtcon_setup_features(struct vtcon_softc *sc) vtcon_setup_features(struct vtcon_softc *sc)
{ {
device_t dev; device_t dev;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
▲ Show 20 Lines • Show All 400 Lines • ▼ Show 20 Linesvtcon_ctrl_port_name_event(struct vtcon_softc *sc, int id, const char *name,
VTCON_PORT_UNLOCK(port); VTCON_PORT_UNLOCK(port);
} }
static void static void
vtcon_ctrl_process_event(struct vtcon_softc *sc, vtcon_ctrl_process_event(struct vtcon_softc *sc,
struct virtio_console_control *control, void *data, size_t data_len) struct virtio_console_control *control, void *data, size_t data_len)
{ {
device_t dev; device_t dev;
int id; uint32_t id;
uint16_t event;
dev = sc->vtcon_dev; dev = sc->vtcon_dev;
id = control->id; id = vtcon_htog32(sc, control->id);
event = vtcon_htog16(sc, control->event);
if (id < 0 || id >= sc->vtcon_max_ports) { if (id >= sc->vtcon_max_ports) {
device_printf(dev, "%s: invalid port ID %d\n", __func__, id); device_printf(dev, "%s: event %d invalid port ID %d\n",
__func__, event, id);
return; return;
} }
switch (control->event) { switch (event) {
case VIRTIO_CONSOLE_PORT_ADD: case VIRTIO_CONSOLE_PORT_ADD:
vtcon_ctrl_port_add_event(sc, id); vtcon_ctrl_port_add_event(sc, id);
break; break;
case VIRTIO_CONSOLE_PORT_REMOVE: case VIRTIO_CONSOLE_PORT_REMOVE:
vtcon_ctrl_port_remove_event(sc, id); vtcon_ctrl_port_remove_event(sc, id);
break; break;
▲ Show 20 Lines • Show All 111 Lines • ▼ Show 20 Lines
vtcon_ctrl_send_control(struct vtcon_softc *sc, uint32_t portid, vtcon_ctrl_send_control(struct vtcon_softc *sc, uint32_t portid,
uint16_t event, uint16_t value) uint16_t event, uint16_t value)
{ {
struct virtio_console_control control; struct virtio_console_control control;
if ((sc->vtcon_flags & VTCON_FLAG_MULTIPORT) == 0) if ((sc->vtcon_flags & VTCON_FLAG_MULTIPORT) == 0)
return; return;
control.id = portid; control.id = vtcon_gtoh32(sc, portid);
control.event = event; control.event = vtcon_gtoh16(sc, event);
control.value = value; control.value = vtcon_gtoh16(sc, value);
vtcon_ctrl_poll(sc, &control); vtcon_ctrl_poll(sc, &control);
} }
static int static int
vtcon_port_enqueue_buf(struct vtcon_port *port, void *buf, size_t len) vtcon_port_enqueue_buf(struct vtcon_port *port, void *buf, size_t len)
{ {
struct sglist_seg segs[2]; struct sglist_seg segs[2];
▲ Show 20 Lines • Show All 504 Lines • Show Last 20 Lines