Differential D32695

LinuxKPI: make bcd.h use libkern
ClosedPublic
Actions

Authored by bz on Oct 27 2021, 5:16 PM.

Tags

None

Referenced Files

	F168637931: D32695.id98708.diff
	Sat, Aug 29, 9:24 AM

	Unknown Object (File)
	Thu, Aug 27, 7:47 AM

	Unknown Object (File)
	Tue, Aug 25, 9:04 PM

	Unknown Object (File)
	Tue, Aug 25, 11:49 AM

	Unknown Object (File)
	Tue, Aug 25, 9:21 AM

	Unknown Object (File)
	Tue, Aug 25, 7:10 AM

	Unknown Object (File)
	Tue, Aug 25, 6:51 AM

	Unknown Object (File)
	Sat, Aug 22, 8:42 AM

Subscribers

Details

Reviewers

• ian
• hselasky

Commits

rGae2268efd5f8: LinuxKPI: make bcd.h use libkern

Summary

Rather than having code to re-define bcd2bin() for the LinuxKPI
make sure libkern.h is always included before the LinuxKPI version.
Then only re-define our local LinuxKPI implementation. [1]

From the argument truncating wrapper call the libkern version.
If we change our libkern implementation in the future we can save
us the remainder of the hassle. [2] Given I need this to MFC,
which I am not sure we can with libkern, commit this intermediate
step.

Suggested by: Johannes Berg (johannes sipsolutions.net) [1]
Suggested by: ian [2]
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
X-MFC with: 548ada00e54a9e7745d041b1ec7f68f3bd493365

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Oct 27 2021, 5:16 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptOct 27 2021, 5:16 PM

bz requested review of this revision.Oct 27 2021, 5:16 PM

Harbormaster completed remote builds in B42403: Diff 97571.Oct 27 2021, 5:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2021, 11:16 PM

Closed by commit rGae2268efd5f8: LinuxKPI: make bcd.h use libkern (authored by bz). · Explain Why

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGae2268efd5f8: LinuxKPI: make bcd.h use libkern.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

14 lines

Diff 98708

sys/compat/linuxkpi/common/include/linux/bcd.h

Loading...