Differential D4054

net80211: add watchdog routines
Needs ReviewPublic
Actions

Authored by avos on Oct 31 2015, 10:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 9:29 PM

	Unknown Object (File)
	Tue, Nov 19, 3:36 AM

	Unknown Object (File)
	Tue, Nov 19, 3:27 AM

	Unknown Object (File)
	Tue, Nov 19, 3:18 AM

	Unknown Object (File)
	Tue, Nov 19, 1:22 AM

	Unknown Object (File)
	Sun, Nov 17, 1:41 PM

	Unknown Object (File)
	Sun, Nov 17, 12:41 PM

	Unknown Object (File)
	Thu, Oct 31, 11:01 PM

View All 61 Files

Subscribers

Details

Reviewers

Summary

This implementation should replace driver-level watchdog implementations (and, as a result, reduce size of driver-specific code).

The watchdog can be enabled via
ic->ic_flags_ext |= IEEE80211_FEXT_WATCHDOG;
code line before calling ieee80211_ifattach();

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

avos updated this revision to Diff 9857.Oct 31 2015, 10:50 PM

avos retitled this revision from to net80211: add watchdog routines.

avos updated this object.

avos edited the test plan for this revision. (Show Details)

avos added a reviewer: adrian.

avos set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 31 2015, 10:50 PM

Call ieee80211_tx_watchdog_refresh() before calling ic_transmit() / ic_raw_xmit(); that adds a possibility to call it from the callee error handler.
Update watchdog timer only when transmission occurs.
Add few more checks.

Fix race between ieee80211_tx_watchdog_stop() and ieee80211_tx_watchdog_refresh().

I would like to resurrect this patch as related to bug reports: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252725 & https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250424

sys/net80211/ieee80211_freebsd.c
575–576	Hi, I would like to ask few questions about this patch. As I see, tx_queued is incremented on transmission, but I don't see how it will be decremented in sunny day scenario. It's int16_t (max = 32768, then overflow)

Herald added subscribers: glebius, melifaro. · View Herald TranscriptAug 2 2024, 7:55 PM

bz mentioned this in D47522: rtwn: change the USB TX transfers to only do one pending transfer per endpoint.Tue, Nov 12, 2:13 PM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

2 lines

ieee80211_freebsd.h

22 lines

ieee80211_freebsd.c

91 lines

ieee80211_output.c

4 lines

ieee80211_proto.c

1 line

ieee80211_var.h

8 lines

Diff 9870

sys/net80211/ieee80211.c

Loading...

sys/net80211/ieee80211_freebsd.h

Loading...

sys/net80211/ieee80211_freebsd.c

Loading...

sys/net80211/ieee80211_output.c

Loading...

sys/net80211/ieee80211_proto.c

Loading...

sys/net80211/ieee80211_var.h

Loading...