Page MenuHomeFreeBSD
Differential D4054

net80211: add watchdog routines
Needs ReviewPublic
Actions

Authored by avos on Oct 31 2015, 10:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 12, 12:05 PM
Unknown Object (File)
Sun, Nov 30, 10:13 AM
Unknown Object (File)
Nov 13 2025, 8:52 PM
Unknown Object (File)
Nov 11 2025, 10:39 PM
Unknown Object (File)
Nov 11 2025, 10:39 PM
Unknown Object (File)
Nov 11 2025, 10:39 PM
Unknown Object (File)
Nov 11 2025, 10:39 PM
Unknown Object (File)
Nov 11 2025, 7:37 PM
View All Files
Subscribers
glebius
imp
melifaro
mizhka

Details

Reviewers
adrian
Summary

This implementation should replace driver-level watchdog implementations (and, as a result, reduce size of driver-specific code).

The watchdog can be enabled via
ic->ic_flags_ext |= IEEE80211_FEXT_WATCHDOG;
code line before calling ieee80211_ifattach();

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos updated this revision to Diff 9857.Oct 31 2015, 10:50 PM
avos retitled this revision from to net80211: add watchdog routines.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptOct 31 2015, 10:50 PM
avos updated this revision to Diff 9870.Nov 1 2015, 10:40 PM
  • Call ieee80211_tx_watchdog_refresh() before calling ic_transmit() / ic_raw_xmit(); that adds a possibility to call it from the callee error handler.
  • Update watchdog timer only when transmission occurs.
  • Add few more checks.
avos updated this revision to Diff 10556.Nov 28 2015, 11:58 PM

Fix race between ieee80211_tx_watchdog_stop() and ieee80211_tx_watchdog_refresh().

mizhka added a subscriber: mizhka.Aug 2 2024, 7:55 PM

I would like to resurrect this patch as related to bug reports: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252725 & https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250424

sys/net80211/ieee80211_freebsd.c
575–576

Hi,

I would like to ask few questions about this patch. As I see, tx_queued is incremented on transmission, but I don't see how it will be decremented in sunny day scenario. It's int16_t (max = 32768, then overflow)

Herald added subscribers: glebius, melifaro. · View Herald TranscriptAug 2 2024, 7:55 PM
bz mentioned this in D47522: rtwn: change the USB TX transfers to only do one pending transfer per endpoint.Nov 12 2024, 2:13 PM

Revision Contents
Changeset List

Diff 9870

View Options

sys/net80211/ieee80211.c

Loading...
View Options

sys/net80211/ieee80211_freebsd.h

Loading...
View Options

sys/net80211/ieee80211_freebsd.c

Loading...
View Options

sys/net80211/ieee80211_output.c

Loading...
View Options

sys/net80211/ieee80211_proto.c

Loading...
View Options

sys/net80211/ieee80211_var.h

Loading...