net: sprinkle __predict_false in ip_input on error conditions
ClosedPublic
Actions

Authored by mjg on Nov 10 2021, 5:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 27, 5:27 PM

	Unknown Object (File)
	Tue, May 14, 11:51 AM

	Unknown Object (File)
	Sun, May 12, 7:14 PM

	Unknown Object (File)
	Sun, May 12, 4:12 PM

	Unknown Object (File)
	Apr 28 2024, 8:15 AM

	Unknown Object (File)
	Apr 26 2024, 12:55 PM

	Unknown Object (File)
	Apr 26 2024, 11:33 AM

	Unknown Object (File)
	Apr 26 2024, 11:32 AM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network

Commits

rG0359e7a5e49f: net: sprinkle __predict_false in ip_input on error conditions

Summary

While here rearrange the RVSP check to inspect proto first and avoid
evaluating V_rsvp in the common case to begin with (most notably avoid
the expensive read).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mjg created this revision.Nov 10 2021, 5:22 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptNov 10 2021, 5:22 PM

mjg requested review of this revision.Nov 10 2021, 5:22 PM

mjg edited the summary of this revision. (Show Details)

One comment not related to the code. As you request reviews from network, maybe add yourself to network, too? Right now there are other patches to ip_input in the network review queue :)

This revision is now accepted and ready to land.Nov 10 2021, 6:07 PM

Closed by commit rG0359e7a5e49f: net: sprinkle __predict_false in ip_input on error conditions (authored by mjg). · Explain WhyNov 12 2021, 3:51 PM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rG0359e7a5e49f: net: sprinkle __predict_false in ip_input on error conditions.