amr64/gicv3: improve a panic message
ClosedPublic
Actions

Authored by bz on Nov 9 2021, 10:16 PM.

Tags

None

Referenced Files

	F163109046: D32917.id98276.diff
	Mon, Jul 20, 3:50 AM

	F163067644: D32917.id98301.diff
	Sun, Jul 19, 7:12 PM

	Unknown Object (File)
	Jun 14 2026, 12:16 AM

	Unknown Object (File)
	Jun 8 2026, 6:43 PM

	Unknown Object (File)
	Jun 8 2026, 5:14 PM

	Unknown Object (File)
	May 13 2026, 9:26 AM

	Unknown Object (File)
	May 7 2026, 1:20 PM

	Unknown Object (File)
	Apr 22 2026, 8:58 AM

View All Files

Subscribers

emaste

imp

Details

Reviewers

andrew
manu
emaste

Commits

rGfad51d34f213: arm64/gicv3: improve a panic message

Summary

Print the device/unit in the panic message for which we cannot get
the MSI device ID to have a clue where to start looking.
While here use func instead of hardcoding the function name.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Nov 9 2021, 10:16 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 9 2021, 10:16 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

bz requested review of this revision.Nov 9 2021, 10:16 PM

Harbormaster completed remote builds in B42686: Diff 98276.Nov 9 2021, 10:16 PM

s/amr64/arm64/ in commit message

LGTM modulo the two comments

sys/arm64/arm64/gicv3_its.c
1127–1128	panics seem to be split on capitalization approach, although the rest of the file seems to use an initial capital so probably leave it so?

This revision is now accepted and ready to land.Nov 10 2021, 12:48 AM

Closed by commit rGfad51d34f213: arm64/gicv3: improve a panic message (authored by bz). · Explain WhyNov 10 2021, 9:46 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGfad51d34f213: arm64/gicv3: improve a panic message.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

gicv3_its.c

3 lines

Diff 98301

View Options

sys/arm64/arm64/gicv3_its.c

amr64/gicv3: improve a panic messageClosedPublicActions