xen/intr: allow xen_intr_release_isrc() to reuse lock
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Nov 7 2021, 4:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 8, 8:58 AM

	Unknown Object (File)
	Mon, Oct 5, 7:39 AM

	Unknown Object (File)
	Mon, Oct 5, 7:17 AM

	Unknown Object (File)
	Mon, Oct 5, 6:58 AM

	Unknown Object (File)
	Fri, Oct 2, 9:06 PM

	Unknown Object (File)
	Sat, Sep 26, 3:40 PM

	Unknown Object (File)
	Sep 7 2026, 11:13 PM

	Unknown Object (File)
	Sep 6 2026, 4:22 PM

View All Files

Subscribers

imp

Details

Reviewers

royger
mhorne

Summary

Calling mtx_unlock() only to immediately call mtx_lock() isn't so great.
Since xen_intr_unbind() already has the main lock held before calling
xen_intr_release_isrc(), avoid the back to back unlock then lock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42642
Build 39530: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Nov 7 2021, 4:25 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 7 2021, 4:25 AM

ehem_freebsd_m5p.com requested review of this revision.Nov 7 2021, 4:25 AM

Harbormaster completed remote builds in B42640: Diff 98151.Nov 7 2021, 4:25 AM

ehem_freebsd_m5p.com added a parent revision: D32876: xen/intr: move handler removal to release from unbind.Nov 7 2021, 4:25 AM

Kind of a "Hey, look what D32876 allows us to do!"

Yes, this got into Phabricator before final testing. Indeed, it is broken. The fix is pretty obvious.

Upon examination I suspect things may head in a different direction.

Harbormaster completed remote builds in B42642: Diff 98163.Nov 7 2021, 7:07 PM

This isn't even the slightest bit of a priority. Worse, this does indeed make locking harrier.

Revision Contents
Changeset List

Path

Size

sys/

xen/

xen_intr.c

4 lines

Diff 98163

View Options

xen/intr: allow xen_intr_release_isrc() to reuse lockAbandonedPublicActions