Differential D32881
WIP: lang/rust: Add riscv64gc-unknown-freebsd target Authored by tobik on Nov 7 2021, 3:33 PM. Tags None Referenced Files
Subscribers
Details
Add riscv64gc-unknown-freebsd target I have had to patch libc and libstd to target FreeBSD 13.x ABI since riscv64 GENERIC does not enable COMPAT_*. TODO:
Built from lang/rust-bootstrap@riscv64 on 13.0-RELEASE amd64 and tested on 13.0-RELEASE riscv64 in a QEMU VM.
$ for c in rust-std cargo rustc; do tar xf $c-1.56.0-riscv64gc-unknown-freebsd.tar.xz (cd $c-1.56.0-riscv64gc-unknown-freebsd; sh install.sh --prefix=~/rust) done
$ echo 'fn main() { println!("hello world") }' >hello.rs $ ~/rust/bin/rustc hello.rs && ./hello hello world As an example I have patched sysutils/hexyl for riscv64 (see sysutils/hexyl/files/patch-riscv64). To test it: $ make -C sysutils/hexyl CARGO_BUILDDEP=no CARGO=~/rust/bin/cargo RUSTC=~/rust/bin/rustc
Diff Detail
Event TimelineComment Actions This looks incomplete, I hacked this up a while ago building from upstream sources with P522 P523 P524 P525 (doesn't include the target.rs, didn't git add that, but it's the same as yours). But this needs resolving properly upstream by having the FreeBSD version propagated properly as cfg info, not by whack-a-mole patching of places all over that RISC-V is FreeBSD 12 and everything else is 11. One place should have that RISC-V-specific knowledge, everywhere else should just be automatic based on what libc or std say. Comment Actions Hopefully everything will migrate to the 12 (ino64) ABI soon: https://github.com/rust-lang/rust/issues/89058 Comment Actions It solves this specific problem, but the underlying issue is just punted two years down the road... Now is the right time to fix it properly. Comment Actions Thanks. Going to add the missing pieces some time this week and rebuild the bootstrap.
Are you working on it? Comment Actions No, I don't have enough time to engage in that kind of discussion with upstream, which is why my work stalled where it did rather than upstreaming any of it. Comment Actions
Comment Actions Why not just add COMPAT_FREEBSD11 to riscv64 kernel? That's what I did for powerpc64le (support added in 13.0) to have Rust working. Comment Actions Yeah, that sounds better than special casing riscv64gc-unknown-freebsd everywhere. Any comments from riscv about that? Is it possible? Comment Actions It's possible, but it's not a solution to the problem, and you shouldn't change the kernel because Rust wants to use syscalls that never existed for the current RISC-V ABI (11.0 had some RISC-V support, but the ISA and toolchain ABI saw breaking changes after that so it's not until 12.0 that you reach the point of compatibility). So I object to that change on the grounds that Rust is broken and we should not carry baggage in the kernel just so it can continue to ignore syscall ABI issues. |