Page MenuHomeFreeBSD

LinuxKPI: make bcd.h use libkern
ClosedPublic

Authored by bz on Oct 27 2021, 5:16 PM.
Tags
None
Referenced Files
F166838735: D32695.id.diff
Sun, Aug 16, 11:08 PM
Unknown Object (File)
Tue, Aug 11, 11:42 PM
Unknown Object (File)
Tue, Aug 11, 3:41 PM
Unknown Object (File)
Mon, Aug 10, 7:05 PM
Unknown Object (File)
Mon, Aug 10, 6:33 PM
Unknown Object (File)
Mon, Aug 10, 12:43 PM
Unknown Object (File)
Mon, Aug 10, 12:35 PM
Unknown Object (File)
Mon, Aug 10, 10:08 AM

Details

Summary

Rather than having code to re-define bcd2bin() for the LinuxKPI
make sure libkern.h is always included before the LinuxKPI version.
Then only re-define our local LinuxKPI implementation. [1]

From the argument truncating wrapper call the libkern version.
If we change our libkern implementation in the future we can save
us the remainder of the hassle. [2] Given I need this to MFC,
which I am not sure we can with libkern, commit this intermediate
step.

Suggested by: Johannes Berg (johannes sipsolutions.net) [1]
Suggested by: ian [2]
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
X-MFC with: 548ada00e54a9e7745d041b1ec7f68f3bd493365

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42403
Build 39291: arc lint + arc unit

Event Timeline

bz requested review of this revision.Oct 27 2021, 5:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 18 2021, 11:16 PM
This revision was automatically updated to reflect the committed changes.