MFC after: 1 week
Sponsored by: NVIDIA Networking
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Excuse me, but I only have stylistic questions.
usr.sbin/beep/beep.c | ||
---|---|---|
28–40 | Sorry, I'm a bit too tired to double check against style(9), but these seem to be in wrong order. | |
68 | Why the ugly underscores? | |
91 | Is this Gray encoding, after Frank Gray? | |
165 | I may be wrong, but I think we want to avoid using atoi() in new code. |
usr.sbin/beep/beep.c | ||
---|---|---|
165 | Indeed atoi(3) says The atoi() function has been deprecated by strtol() and should not be used in new code. |
usr.sbin/beep/beep.8 | ||
---|---|---|
4 | Yeah the standard copyright template for new code no longer has this. It's not a big deal but serves no purpose so if there's no other reason to include it (e.g. your employer requires it) then I'd leave it out. |
Thanks for all comments. I'll address them later today.
usr.sbin/beep/beep.c | ||
---|---|---|
91 | Yes, I'll fix the spelling. |
usr.sbin/beep/beep.c | ||
---|---|---|
68 | I'll fix it. |
usr.sbin/beep/beep.c | ||
---|---|---|
39 | clang-format says: include <sys/soundcard.h> #include <err.h> #include <errno.h> #include <fcntl.h> #include <math.h> #include <paths.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <unistd.h> |
usr.bin/beep/beep.1 | ||
---|---|---|
50 ↗ | (On Diff #97676) | I don't have the authority to say for sure, but I think we should use space to separate the numbers from the units here and below. |
usr.bin/beep/beep.1 | ||
---|---|---|
61 ↗ | (On Diff #97678) | Typo, inclusively. |