bpf: Fix the write filter
ClosedPublic
Actions

Authored by markj on Oct 19 2021, 4:36 PM.

Details

Reviewers

ae
harti

Group Reviewers

manpages

Commits

rG426682b05a4c: bpf: Fix the write filter for detached descriptors

Summary

A BPF descriptor only has an associated interface descriptor once it is
attached to an interface, e.g., with BIOCSETIF. Avoid dereferencing a
NULL pointer in filt_bpfwrite() if the BPF descriptor is not attached.

Fixes: ded77e0237a8 ("Allow the BPF to be select for write.")
Reported by: syzbot+ae45d5166afe15a5a21d@syzkaller.appspotmail.com

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42255
Build 39143: arc lint + arc unit

Event Timeline

markj created this revision.Oct 19 2021, 4:36 PM

Herald added a reviewer: manpages. · View Herald TranscriptOct 19 2021, 4:36 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

markj requested review of this revision.Oct 19 2021, 4:36 PM

Harbormaster completed remote builds in B42255: Diff 97110.Oct 19 2021, 4:36 PM

LGTM.

This revision is now accepted and ready to land.Oct 20 2021, 7:57 AM

Closed by commit rG426682b05a4c: bpf: Fix the write filter for detached descriptors (authored by markj). · Explain WhyOct 26 2021, 2:01 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG426682b05a4c: bpf: Fix the write filter for detached descriptors.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

kqueue.2

4 lines

sys/

net/

bpf.c

15 lines

Diff 97110

View Options

lib/libc/sys/kqueue.2