Page MenuHomeFreeBSD
Differential D32542

Fix cross-building on Linux/aarch64
ClosedPublic
Actions

Authored by kevans on Oct 18 2021, 2:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 12, 10:15 PM
Unknown Object (File)
Wed, Aug 12, 8:57 PM
Unknown Object (File)
Mon, Aug 10, 10:11 AM
Unknown Object (File)
Sun, Aug 9, 11:28 PM
Unknown Object (File)
Sun, Aug 9, 11:27 PM
Unknown Object (File)
Sun, Aug 9, 6:17 PM
Unknown Object (File)
Sat, Aug 8, 4:26 AM
Unknown Object (File)
Sat, Aug 8, 4:02 AM
View All Files
Subscribers
imp

Details

Reviewers
allanjude
emaste
imp
arichardson
Commits
rG8c22b9f3ba58: Fix cross-building on Linux/aarch64
Summary

Add necessary bits to detect ELF format on Linux/aarch64; note that
Linux calls it aarch64 where we would typically call it arm64 (uname -m)

Sponsored by: Klara, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42213
Build 39101: arc lint + arc unit

Event Timeline

kevans created this revision.Oct 18 2021, 2:28 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 18 2021, 2:28 AM
kevans requested review of this revision.Oct 18 2021, 2:28 AM
Harbormaster completed remote builds in B42213: Diff 97029.Oct 18 2021, 2:28 AM
kevans added a reviewer: emaste.Oct 18 2021, 2:28 AM
imp accepted this revision.Oct 18 2021, 3:02 AM

I have other comments on the makefile since it seems to confuse machine and machine_arch in the terminology. But that's beyond the scope of this change...

This revision is now accepted and ready to land.Oct 18 2021, 3:02 AM
arichardson accepted this revision.Oct 18 2021, 1:05 PM
arichardson removed a reviewer: arichardson.

A lot of that makefile is a bit confusing since I tried to get things to work without understanding everything... But since this fixed the build LGTM.

arichardson added inline comments.Oct 18 2021, 1:06 PM
contrib/elftoolchain/common/native-elf-format
42

I'd quite like it if we didn't need this script, but that is extremely low priority.

emaste accepted this revision.Oct 18 2021, 1:16 PM
emaste added inline comments.
contrib/elftoolchain/common/native-elf-format
42

See https://sourceforge.net/p/elftoolchain/code/3922

Closed by commit rG8c22b9f3ba58: Fix cross-building on Linux/aarch64 (authored by kevans). · Explain WhyOct 18 2021, 4:09 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG8c22b9f3ba58: Fix cross-building on Linux/aarch64.

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
common/
2 lines
tools/
build/
3 lines

Diff 97029

View Options

contrib/elftoolchain/common/native-elf-format

Loading...
View Options

tools/build/Makefile

Loading...