Differential D32491

cxgbe: Only run ktls_tick when NIC TLS is enabled.
ClosedPublic
Actions

Authored by jhb on Oct 13 2021, 9:11 PM.

Tags

None

Referenced Files

	F159819645: D32491.id96843.diff
	Thu, Jun 18, 1:29 PM

	F159779027: D32491.id.diff
	Thu, Jun 18, 3:55 AM

	Unknown Object (File)
	Wed, Jun 17, 11:10 AM

	Unknown Object (File)
	Mon, Jun 15, 5:59 PM

	Unknown Object (File)
	Mon, Jun 15, 5:58 PM

	Unknown Object (File)
	Apr 29 2026, 12:42 AM

	Unknown Object (File)
	Apr 28 2026, 7:38 AM

	Unknown Object (File)
	Apr 27 2026, 2:12 AM

Subscribers

Details

Reviewers

np
mav

Commits

rGff590791ff6d: cxgbe: Only run ktls_tick when NIC TLS is enabled.
rGef3f98ae4778: cxgbe: Only run ktls_tick when NIC TLS is enabled.

Summary

Previously the body of ktls_tick was a nop when NIC TLS was disabled,
but the callout was still scheduled consuming power on otherwise-idle
systems with Chelsio T6 adapters. Now the callout only runs while NIC
TLS is enabled on at least one interface of an adapter.

Reported by: mav
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 13 2021, 9:11 PM

Herald added subscribers: ae, imp. · View Herald TranscriptOct 13 2021, 9:11 PM

jhb requested review of this revision.Oct 13 2021, 9:11 PM

Harbormaster completed remote builds in B42131: Diff 96843.Oct 13 2021, 9:11 PM

I haven't tested, but looks good to me. Thanks,

This revision is now accepted and ready to land.Oct 13 2021, 9:20 PM

np accepted this revision.Oct 13 2021, 11:30 PM

Closed by commit rGef3f98ae4778: cxgbe: Only run ktls_tick when NIC TLS is enabled. (authored by jhb). · Explain WhyOct 14 2021, 6:01 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGef3f98ae4778: cxgbe: Only run ktls_tick when NIC TLS is enabled..

jhb added a commit: rGff590791ff6d: cxgbe: Only run ktls_tick when NIC TLS is enabled..Nov 23 2021, 11:13 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

21 lines

Diff 96875

sys/dev/cxgbe/t4_main.c

Loading...