Page MenuHomeFreeBSD
Differential D32488

pfctl: delay label macro expansion until after rule optimisation
ClosedPublic
Actions

Authored by kp on Oct 13 2021, 8:03 PM.
Tags
None
Referenced Files
F166701390: D32488.diff
Sat, Aug 15, 6:06 PM
Unknown Object (File)
Fri, Aug 14, 1:30 AM
Unknown Object (File)
Fri, Aug 14, 1:28 AM
Unknown Object (File)
Wed, Aug 12, 5:04 PM
Unknown Object (File)
Tue, Aug 11, 11:56 PM
Unknown Object (File)
Tue, Aug 11, 5:48 AM
Unknown Object (File)
Mon, Aug 10, 5:05 PM
Unknown Object (File)
Mon, Aug 10, 6:37 AM
View All Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rG6358f57209e2: pfctl: delay label macro expansion until after rule optimisation
rG35237559a6a0: pfctl: delay label macro expansion until after rule optimisation
rG09c7f2386973: pfctl: delay label macro expansion until after rule optimisation
Summary

We used to expand the $nr macro in labels into the rule number prior to
the optimisation step. This would occasionally produce incorrect rule
numbers in the labels.

Delay all macro expansion until after the optimisation step to ensure
that we expand the correct values.

MFC after: 1 week
Reported by: Özkan KIRIK <ozkan.kirik@gmail.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42129
Build 39017: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
85 lines
2 lines
6 lines

Diff 96839

View Options

sbin/pfctl/parse.y

Loading...
View Options

sbin/pfctl/pfctl.h

Loading...
View Options

sbin/pfctl/pfctl.c

Loading...