Page MenuHomeFreeBSD

pfctl: delay label macro expansion until after rule optimisation
ClosedPublic

Authored by kp on Oct 13 2021, 8:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 11:48 PM
Unknown Object (File)
Mon, Apr 29, 11:47 PM
Unknown Object (File)
Mon, Apr 29, 11:47 PM
Unknown Object (File)
Mon, Apr 29, 1:17 PM
Unknown Object (File)
Apr 4 2024, 7:17 AM
Unknown Object (File)
Apr 4 2024, 7:17 AM
Unknown Object (File)
Apr 4 2024, 7:17 AM
Unknown Object (File)
Apr 4 2024, 7:16 AM
Subscribers

Details

Summary

We used to expand the $nr macro in labels into the rule number prior to
the optimisation step. This would occasionally produce incorrect rule
numbers in the labels.

Delay all macro expansion until after the optimisation step to ensure
that we expand the correct values.

MFC after: 1 week
Reported by: Özkan KIRIK <ozkan.kirik@gmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable