Page MenuHomeFreeBSD
Differential D31960

graphics/gtk-update-icon-cache: use triggers
ClosedPublic
Actions

Authored by bapt on Sep 14 2021, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 11:30 AM
Unknown Object (File)
Tue, Mar 18, 2:39 PM
Unknown Object (File)
Thu, Mar 13, 7:07 AM
Unknown Object (File)
Thu, Feb 27, 6:39 PM
Unknown Object (File)
Feb 16 2025, 8:51 AM
Unknown Object (File)
Feb 15 2025, 6:03 PM
Unknown Object (File)
Feb 15 2025, 5:49 PM
Unknown Object (File)
Feb 15 2025, 5:41 PM
View All Files
Subscribers
Alexander88207_protonmail.com
mat

Details

Reviewers
tcberner
Group Reviewers
portmgr
Commits
R11:46bcb098c82f: graphics/gtk-update-icon-cache: use triggers
R11:6f5d234138dc: framework: new USES trigger
Summary

Use triggers instead of enforcing the INSTALL_ICONS which enforces
gtk-update-icon-cache dependency on every ports installing icons.

The bonus:

  • factorize gtk-update-icon-cache update at the end of the build
  • stop adding a gratuicious dependency on gtk-update-icon-cache on packages which do not need it
  • works on packages where INSTALLS_ICONS were forgotten

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt created this revision.Sep 14 2021, 3:29 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 14 2021, 3:29 PM
Herald added a subscriber: mat. · View Herald Transcript
bapt requested review of this revision.Sep 14 2021, 3:29 PM
Harbormaster completed remote builds in B41511: Diff 95153.Sep 14 2021, 3:30 PM
bapt updated this revision to Diff 95154.Sep 14 2021, 4:03 PM

Create USES=trigger to simplify everything

Harbormaster completed remote builds in B41512: Diff 95154.Sep 14 2021, 4:03 PM
tcberner added a comment.Sep 14 2021, 4:08 PM
In D31960#720956, @bapt wrote:

Create USES=trigger to simplify everything

very nice

tcberner added inline comments.Sep 14 2021, 4:09 PM
Mk/Uses/trigger.mk
7

maybe add
defaults to ${PORTNAME}.

tcberner added a comment.Sep 14 2021, 4:13 PM

I assume the obsolete INSTALLS_ICONS lines in all the other ports are just not part of this review for brevity?

Alexander88207_protonmail.com added a subscriber: Alexander88207_protonmail.com.Sep 20 2021, 5:23 AM
bapt updated this revision to Diff 95433.Sep 21 2021, 8:29 AM

Fix leftovers

Harbormaster completed remote builds in B41617: Diff 95433.Sep 21 2021, 8:29 AM
bapt marked an inline comment as done.Sep 23 2021, 7:59 PM
bapt updated this revision to Diff 96106.Oct 1 2021, 8:29 PM

Fix share/icons leftover

Harbormaster completed remote builds in B41903: Diff 96106.Oct 1 2021, 8:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2021, 5:47 PM
Closed by commit R11:6f5d234138dc: framework: new USES trigger (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: R11:6f5d234138dc: framework: new USES trigger.
bapt added a commit: R11:46bcb098c82f: graphics/gtk-update-icon-cache: use triggers.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
25 lines
29 lines

Diff 96630

View Options

Mk/Uses/gnome.mk

Show First 20 Lines • Show All 207 Lines • ▼ Show 20 Lines
is implemented through the is implemented through the
.Xr cron 8 .Xr cron 8
daemon by calling daemon by calling
.Xr atrun 8 .Xr atrun 8
every five minutes. every five minutes.
This implies that the granularity of This implies that the granularity of
.Nm .Nm
might not be optimal for every deployment. might not be optimal for every deployment.
If a finer granularity is needed, the system crontab at If a finer granularity is desired, the
pauamma_gundo.comUnsubmitted
Not Done
Inline Actions

Since you're touching that line anyway, maybe s/finer granularity/shorter interval/ at the same time?

pauamma_gundo.com: Since you're touching that line anyway, maybe s/finer granularity/shorter interval/ at the same…
debdrupAuthorUnsubmitted
Done
Inline Actions

It's not just a shorter interval that 'at' offers, it can be at 4 minutes 42 seconds or 5 minutes 42 seconds - so finer granularity is the correct wording.

debdrup: It's not just a shorter interval that 'at' offers, it can be at 4 minutes 42 seconds or 5…
.Pa /etc/crontab .Pa /etc/cron.d/at
needs to be changed. file can be edited and will be read by the system crontab, from which
the SHELL and PATH environment variables are inherited.
.Sh OPTIONS .Sh OPTIONS
.Bl -tag -width indent .Bl -tag -width indent
.It Fl q Ar queue .It Fl q Ar queue
Use the specified queue. Use the specified queue.
A queue designation consists of a single letter; valid queue designations A queue designation consists of a single letter; valid queue designations
range from range from
.Ar a .Ar a
to to
▲ Show 20 Lines • Show All 137 Lines • Show Last 20 Lines
View Options

Mk/Uses/trigger.mk

Show First 20 Lines • Show All 207 Lines • ▼ Show 20 Lines
is implemented through the is implemented through the
.Xr cron 8 .Xr cron 8
daemon by calling daemon by calling
.Xr atrun 8 .Xr atrun 8
every five minutes. every five minutes.
This implies that the granularity of This implies that the granularity of
.Nm .Nm
might not be optimal for every deployment. might not be optimal for every deployment.
If a finer granularity is needed, the system crontab at If a finer granularity is desired, the
pauamma_gundo.comUnsubmitted
Not Done
Inline Actions

Since you're touching that line anyway, maybe s/finer granularity/shorter interval/ at the same time?

pauamma_gundo.com: Since you're touching that line anyway, maybe s/finer granularity/shorter interval/ at the same…
debdrupAuthorUnsubmitted
Done
Inline Actions

It's not just a shorter interval that 'at' offers, it can be at 4 minutes 42 seconds or 5 minutes 42 seconds - so finer granularity is the correct wording.

debdrup: It's not just a shorter interval that 'at' offers, it can be at 4 minutes 42 seconds or 5…
.Pa /etc/crontab .Pa /etc/cron.d/at
needs to be changed. file can be edited and will be read by the system crontab, from which
the SHELL and PATH environment variables are inherited.
.Sh OPTIONS .Sh OPTIONS
.Bl -tag -width indent .Bl -tag -width indent
.It Fl q Ar queue .It Fl q Ar queue
Use the specified queue. Use the specified queue.
A queue designation consists of a single letter; valid queue designations A queue designation consists of a single letter; valid queue designations
range from range from
.Ar a .Ar a
to to
▲ Show 20 Lines • Show All 137 Lines • Show Last 20 Lines