Page MenuHomeFreeBSD
Differential D31960

graphics/gtk-update-icon-cache: use triggers
ClosedPublic
Actions

Authored by bapt on Sep 14 2021, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 20, 5:08 AM
Unknown Object (File)
Thu, Aug 20, 3:14 AM
Unknown Object (File)
Sun, Aug 16, 4:16 PM
Unknown Object (File)
Sun, Aug 9, 3:12 PM
Unknown Object (File)
Sun, Aug 9, 2:16 PM
Unknown Object (File)
Sun, Aug 9, 9:43 AM
Unknown Object (File)
Sun, Aug 9, 9:28 AM
Unknown Object (File)
Sun, Aug 9, 9:27 AM
View All Files
Subscribers
Alexander88207_protonmail.com
mat

Details

Reviewers
tcberner
Group Reviewers
portmgr
Commits
R11:46bcb098c82f: graphics/gtk-update-icon-cache: use triggers
R11:6f5d234138dc: framework: new USES trigger
Summary

Use triggers instead of enforcing the INSTALL_ICONS which enforces
gtk-update-icon-cache dependency on every ports installing icons.

The bonus:

  • factorize gtk-update-icon-cache update at the end of the build
  • stop adding a gratuicious dependency on gtk-update-icon-cache on packages which do not need it
  • works on packages where INSTALLS_ICONS were forgotten

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 41903
Build 38791: arc lint + arc unit

Event Timeline

bapt created this revision.Sep 14 2021, 3:29 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptSep 14 2021, 3:29 PM
Herald added a subscriber: mat. · View Herald Transcript
bapt requested review of this revision.Sep 14 2021, 3:29 PM
Harbormaster completed remote builds in B41511: Diff 95153.Sep 14 2021, 3:30 PM
bapt updated this revision to Diff 95154.Sep 14 2021, 4:03 PM

Create USES=trigger to simplify everything

Harbormaster completed remote builds in B41512: Diff 95154.Sep 14 2021, 4:03 PM
tcberner added a comment.Sep 14 2021, 4:08 PM
In D31960#720956, @bapt wrote:

Create USES=trigger to simplify everything

very nice

tcberner added inline comments.Sep 14 2021, 4:09 PM
Mk/Uses/trigger.mk
7

maybe add
defaults to ${PORTNAME}.

tcberner added a comment.Sep 14 2021, 4:13 PM

I assume the obsolete INSTALLS_ICONS lines in all the other ports are just not part of this review for brevity?

Alexander88207_protonmail.com added a subscriber: Alexander88207_protonmail.com.Sep 20 2021, 5:23 AM
bapt updated this revision to Diff 95433.Sep 21 2021, 8:29 AM

Fix leftovers

Harbormaster completed remote builds in B41617: Diff 95433.Sep 21 2021, 8:29 AM
bapt marked an inline comment as done.Sep 23 2021, 7:59 PM
bapt updated this revision to Diff 96106.Oct 1 2021, 8:29 PM

Fix share/icons leftover

Harbormaster completed remote builds in B41903: Diff 96106.Oct 1 2021, 8:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2021, 5:47 PM
Closed by commit R11:6f5d234138dc: framework: new USES trigger (authored by bapt). · Explain Why
This revision was automatically updated to reflect the committed changes.
bapt added a commit: R11:6f5d234138dc: framework: new USES trigger.
bapt added a commit: R11:46bcb098c82f: graphics/gtk-update-icon-cache: use triggers.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
25 lines
29 lines
graphics/
gtk-update-icon-cache/
3 lines
files/
30 lines

Diff 96106

View Options

Mk/Uses/gnome.mk

Loading...
View Options

Mk/Uses/trigger.mk

Loading...
View Options

graphics/gtk-update-icon-cache/Makefile

Loading...
View Options

graphics/gtk-update-icon-cache/files/gtk-update-icon-cache.ucl.in

Loading...