Page MenuHomeFreeBSD

graphics/gtk-update-icon-cache: use triggers
Needs ReviewPublic

Authored by bapt on Tue, Sep 14, 3:29 PM.

Details

Reviewers
tcberner
Group Reviewers
portmgr
Summary

Use triggers instead of enforcing the INSTALL_ICONS which enforces
gtk-update-icon-cache dependency on every ports installing icons.

The bonus:

  • factorize gtk-update-icon-cache update at the end of the build
  • stop adding a gratuicious dependency on gtk-update-icon-cache on packages which do not need it
  • works on packages where INSTALLS_ICONS were forgotten

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 41617
Build 38506: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Tue, Sep 14, 3:29 PM

Create USES=trigger to simplify everything

In D31960#720956, @bapt wrote:

Create USES=trigger to simplify everything

very nice

Mk/Uses/trigger.mk
6

maybe add
defaults to ${PORTNAME}.

I assume the obsolete INSTALLS_ICONS lines in all the other ports are just not part of this review for brevity?

bapt marked an inline comment as done.Thu, Sep 23, 7:59 PM