Page MenuHomeFreeBSD

graphics/gtk-update-icon-cache: use triggers
ClosedPublic

Authored by bapt on Sep 14 2021, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 6:33 PM
Unknown Object (File)
Feb 20 2024, 6:33 PM
Unknown Object (File)
Feb 20 2024, 6:33 PM
Unknown Object (File)
Feb 20 2024, 6:33 PM
Unknown Object (File)
Feb 20 2024, 6:33 PM
Unknown Object (File)
Feb 20 2024, 6:33 PM
Unknown Object (File)
Feb 20 2024, 6:20 PM
Unknown Object (File)
Jan 28 2024, 7:10 AM

Details

Summary

Use triggers instead of enforcing the INSTALL_ICONS which enforces
gtk-update-icon-cache dependency on every ports installing icons.

The bonus:

  • factorize gtk-update-icon-cache update at the end of the build
  • stop adding a gratuicious dependency on gtk-update-icon-cache on packages which do not need it
  • works on packages where INSTALLS_ICONS were forgotten

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt requested review of this revision.Sep 14 2021, 3:29 PM

Create USES=trigger to simplify everything

In D31960#720956, @bapt wrote:

Create USES=trigger to simplify everything

very nice

Mk/Uses/trigger.mk
7

maybe add
defaults to ${PORTNAME}.

I assume the obsolete INSTALLS_ICONS lines in all the other ports are just not part of this review for brevity?

bapt marked an inline comment as done.Sep 23 2021, 7:59 PM

Fix share/icons leftover

This revision was not accepted when it landed; it landed in state Needs Review.Oct 10 2021, 5:47 PM
This revision was automatically updated to reflect the committed changes.