Page MenuHomeFreeBSD

net80211: proper ssid length check in setmlme_assoc_adhoc()
ClosedPublic

Authored by bz on Oct 6 2021, 6:50 PM.
Tags
None
Referenced Files
F153613279: D32341.id.diff
Wed, Apr 22, 8:23 AM
Unknown Object (File)
Tue, Apr 21, 8:03 AM
Unknown Object (File)
Tue, Apr 21, 8:00 AM
Unknown Object (File)
Tue, Apr 14, 9:53 PM
Unknown Object (File)
Sun, Apr 12, 6:42 PM
Unknown Object (File)
Sat, Apr 11, 10:47 PM
Unknown Object (File)
Tue, Apr 7, 8:15 AM
Unknown Object (File)
Mon, Apr 6, 3:48 PM
Subscribers

Details

Summary

A user supplied SSID length is used without proper checks in
setmlme_assoc_adhoc() which can lead to copies beyond the end
of the user supplied buffer.
The ssid is a fixed size array for the ioctl and the argument
to setmlme_assoc_adhoc().
In addition to an ssid_len check of 0 also error in case the
ssid_len is larger than the size of the ssid array to prevent
problems.

PR: 254737
Reported by: Tommaso (cutesmilee.research protonmail.com)
MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41989
Build 38877: arc lint + arc unit