mixer(3): add symbol versioning
ClosedPublic
Actions

Authored by christos on Oct 1 2021, 10:20 AM.

Details

Reviewers

Commits

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

christos requested review of this revision.Oct 1 2021, 10:20 AM

christos created this revision.

• hselasky added inline comments.

lib/libmixer/Symbol.map
23	macros don't belong here.

lib/libmixer/Makefile
9	The MLINKS should probably be an own patch.

Remove macros and MLINKS.

Looks good to me.

This revision is now accepted and ready to land.Oct 1 2021, 10:28 AM

lib/libmixer/Symbol.map
5	No, we do not do it this way. Please look at other libs with symbol version used, for instance libprocstat which seems to be a good example. There is a single namespace per release, for 14 it is FBSD_1.7. So put the lib' symbols under this version. Versions are defined in lib/libc/Versions.def, again please take a look at libprocstat/Makefile how to reference it. Also, formally to keep ABI backward compatible we would need to bump libmixer so version, but I do not see a point to go through this relatively painful procedure for head-only library still under development.