Page MenuHomeFreeBSD

mmc: Fix regression in 8a8166e5bcfb breaking Stratix 10 boot
ClosedPublic

Authored by jrtc27 on Sep 28 2021, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 13, 10:21 AM
Unknown Object (File)
Fri, Sep 11, 2:53 PM
Unknown Object (File)
Thu, Sep 10, 9:59 AM
Unknown Object (File)
Sun, Sep 6, 1:12 AM
Unknown Object (File)
Sat, Sep 5, 3:44 PM
Unknown Object (File)
Sat, Sep 5, 6:45 AM
Unknown Object (File)
Sat, Sep 5, 6:27 AM
Unknown Object (File)
Sat, Sep 5, 1:35 AM
Subscribers

Details

Summary

The refactoring in 8a8166e5bcfb introduced a functional change that
breaks booting on the Stratix 10, hanging when it should be attaching
da0. Previously OF_getencprop was called with a pointer to host->f_max,
so if it wasn't present then the existing value was left untouched, but
after that commit it will instead clobber the value with 0. The dwmmc
driver, as used on the Stratix 10, sets a default value before calling
mmc_fdt_parse and so was broken by this functional change. It appears
that aw_mmc also does the same thing, so was presumably also broken on
some boards.

Fixes: 8a8166e5bcfb ("mmc: switch mmc_helper to device_ api")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable