Page MenuHomeFreeBSD

mmc: Fix regression in 8a8166e5bcfb breaking Stratix 10 boot
ClosedPublic

Authored by jrtc27 on Sep 28 2021, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 17, 3:06 AM
Unknown Object (File)
Mon, Mar 16, 10:02 AM
Unknown Object (File)
Sun, Mar 15, 9:59 PM
Unknown Object (File)
Sun, Mar 15, 6:30 AM
Unknown Object (File)
Sat, Mar 14, 9:38 PM
Unknown Object (File)
Sat, Mar 14, 3:40 PM
Unknown Object (File)
Sat, Mar 14, 6:47 AM
Unknown Object (File)
Sat, Mar 14, 3:37 AM
Subscribers

Details

Summary

The refactoring in 8a8166e5bcfb introduced a functional change that
breaks booting on the Stratix 10, hanging when it should be attaching
da0. Previously OF_getencprop was called with a pointer to host->f_max,
so if it wasn't present then the existing value was left untouched, but
after that commit it will instead clobber the value with 0. The dwmmc
driver, as used on the Stratix 10, sets a default value before calling
mmc_fdt_parse and so was broken by this functional change. It appears
that aw_mmc also does the same thing, so was presumably also broken on
some boards.

Fixes: 8a8166e5bcfb ("mmc: switch mmc_helper to device_ api")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41816
Build 38704: arc lint + arc unit