Page MenuHomeFreeBSD
Differential D31905

netpfil tests: extend dummynet tests to pf
ClosedPublic
Actions

Authored by kp on Sep 10 2021, 4:25 PM.
Tags
None
Referenced Files
F83606078: D31905.diff
Sun, May 12, 2:22 PM
Unknown Object (File)
Sun, May 5, 3:22 AM
Unknown Object (File)
Sat, Apr 27, 4:21 AM
Unknown Object (File)
Sat, Apr 27, 3:00 AM
Unknown Object (File)
Thu, Apr 25, 2:58 PM
Unknown Object (File)
Thu, Apr 25, 1:21 PM
Unknown Object (File)
Sat, Apr 20, 2:16 PM
Unknown Object (File)
Fri, Apr 19, 8:48 PM
View All 42 Files
Subscribers
donner
imp
melifaro

Details

Reviewers
donner
Group Reviewers
network
pfsense
Commits
rGab55fa11b38f: netpfil tests: extend dummynet tests to pf
Summary

Now that pf can also use dummynet we should extend the existing dummynet
tests to also test it when used with pf.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sep 10 2021, 4:25 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 10 2021, 4:25 PM
kp requested review of this revision.Sep 10 2021, 4:25 PM
Harbormaster completed remote builds in B41463: Diff 94959.Sep 10 2021, 4:25 PM
kp added a parent revision: D31904: pf: support dummynet.Sep 10 2021, 4:25 PM
kp added a child revision: D31906: man dummynet: dummynet can also be used with pf.
donner accepted this revision as: donner.Sep 10 2021, 6:45 PM
donner added a subscriber: donner.

The rules of pf does not replicate exactly the same logic as the ipfw ones.
This might be insignificant how, but causes extra headache, if the test fails in an interesting way ...

This revision is now accepted and ready to land.Sep 10 2021, 6:45 PM
Closed by commit rGab55fa11b38f: netpfil tests: extend dummynet tests to pf (authored by kp). · Explain WhySep 24 2021, 9:46 AM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGab55fa11b38f: netpfil tests: extend dummynet tests to pf.

Revision Contents
Changeset List

PathSize
tests/
sys/
netpfil/
common/
32 lines
9 lines

Diff 95619

View Options

tests/sys/netpfil/common/dummynet.sh

Loading...
View Options

tests/sys/netpfil/common/utils.subr

Loading...