Paths

Table of Contentst

Differential D31283

Measure latency of PMC interruptions
ClosedPublic
Actions

Authored by wma on Jul 23 2021, 8:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 10, 6:10 PM

	Unknown Object (File)
	Sun, Mar 8, 7:25 PM

	Unknown Object (File)
	Sun, Mar 8, 4:55 PM

	Unknown Object (File)
	Fri, Mar 6, 11:02 AM

	Unknown Object (File)
	Fri, Mar 6, 8:06 AM

	Unknown Object (File)
	Tue, Mar 3, 11:59 PM

	Unknown Object (File)
	Mon, Mar 2, 11:21 PM

	Unknown Object (File)
	Sun, Feb 22, 11:10 PM

Subscribers

Details

Reviewers

jhb
mw
kib

Commits

rG6fa041d7f125: Measure latency of PMC interruptions

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma requested review of this revision.Jul 23 2021, 8:09 AM

wma created this revision.

wma added a reviewer: kib.

kib added inline comments.Jul 23 2021, 5:57 PM

sys/kern/kern_intr.c
79	I suggest to have it_waiting defined always, the effect on memory usage is minuscule.
80	What is the locking protocol for it_waiting? Is it locked by it_thread thread lock?
1031	Can you explain the desired semantic for intr waiting_5 soft event?

mhorne added a subscriber: mhorne.Jul 28 2021, 1:56 PM

Good point about locking. I modified the code to use atomics instead.

Also, removed waiting_5 and let the user to choose the threshold when the PMC event is triggered (default = 1).

Any further comments?

In D31283#714889, @wma wrote:

Any further comments?

New soft events should be documented in the pmc.soft(3) man page.

sys/kern/kern_intr.c
1465	Why not pass `frame` here?

wma updated this revision to Diff 94412.Aug 31 2021, 8:07 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 13 2021, 4:12 AM

Closed by commit rG6fa041d7f125: Measure latency of PMC interruptions (authored by wma). · Explain Why

This revision was automatically updated to reflect the committed changes.

wma added a commit: rG6fa041d7f125: Measure latency of PMC interruptions.

wma updated this revision to Diff 95438.Sep 21 2021, 8:52 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

26 lines

Diff 95438

sys/kern/kern_intr.c

Loading...