Page MenuHomeFreeBSD
Differential D31949

arm64: Fix a logic bug in is_load_instr().
ClosedPublic
Actions

Authored by jhb on Sep 13 2021, 6:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 19, 4:27 PM
Unknown Object (File)
Wed, Aug 19, 4:08 PM
Unknown Object (File)
Tue, Aug 18, 8:50 PM
Unknown Object (File)
Tue, Aug 18, 8:38 PM
Unknown Object (File)
Tue, Aug 18, 8:20 PM
Unknown Object (File)
Tue, Aug 18, 8:17 PM
Unknown Object (File)
Tue, Aug 18, 3:20 PM
Unknown Object (File)
Mon, Aug 10, 12:17 PM
View All Files
Subscribers
imp

Details

Reviewers
andrew
emaste
manu
Commits
rG37179c47d76a: arm64: Fix a logic bug in is_load_instr().
rG8753039a8f23: arm64: Fix a logic bug in is_load_instr().
Summary

Logical and ('&&') was used to join two conditions instead of logical
or ('||') causing some store instructions to not be recognized.

Reported by: GCC 9 -Wparentheses

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Sep 13 2021, 6:30 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 13 2021, 6:30 PM
Herald added a subscriber: imp. · View Herald Transcript
jhb requested review of this revision.Sep 13 2021, 6:30 PM
Harbormaster completed remote builds in B41503: Diff 95075.Sep 13 2021, 6:30 PM
andrew accepted this revision.Sep 15 2021, 9:12 AM

I wonder if we need this. The store macro looks broken, they are only used in ddb to count instructions, and are defined as 0 on most architectures.

This revision is now accepted and ready to land.Sep 15 2021, 9:12 AM
jhb added a comment.Sep 15 2021, 3:58 PM

I have no idea if this is needed or not TBH.

Closed by commit rG8753039a8f23: arm64: Fix a logic bug in is_load_instr(). (authored by jhb). · Explain WhySep 15 2021, 4:07 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG8753039a8f23: arm64: Fix a logic bug in is_load_instr()..
jhb added a commit: rG37179c47d76a: arm64: Fix a logic bug in is_load_instr()..May 10 2022, 11:24 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
include/
2 lines

Diff 95213

View Options

sys/arm64/include/db_machdep.h

Loading...