Differential D31905

netpfil tests: extend dummynet tests to pf
ClosedPublic
Actions

Authored by kp on Sep 10 2021, 4:25 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGab55fa11b38f: netpfil tests: extend dummynet tests to pf

Summary

Now that pf can also use dummynet we should extend the existing dummynet
tests to also test it when used with pf.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41463
Build 38352: arc lint + arc unit

Event Timeline

kp created this revision.Sep 10 2021, 4:25 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptSep 10 2021, 4:25 PM

kp requested review of this revision.Sep 10 2021, 4:25 PM

Harbormaster completed remote builds in B41463: Diff 94959.Sep 10 2021, 4:25 PM

kp added a parent revision: D31904: pf: support dummynet.Sep 10 2021, 4:25 PM

kp added a child revision: D31906: man dummynet: dummynet can also be used with pf.

The rules of pf does not replicate exactly the same logic as the ipfw ones.
This might be insignificant how, but causes extra headache, if the test fails in an interesting way ...

This revision is now accepted and ready to land.Sep 10 2021, 6:45 PM

Closed by commit rGab55fa11b38f: netpfil tests: extend dummynet tests to pf (authored by kp). · Explain WhySep 24 2021, 9:46 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGab55fa11b38f: netpfil tests: extend dummynet tests to pf.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

common/

dummynet.sh

32 lines

utils.subr

9 lines

Diff 94959

View Options

tests/sys/netpfil/common/dummynet.sh