Page MenuHomeFreeBSD
Differential D3926

iicbus: Use device_delete_children() instead of explicit child removal
ClosedPublic
Actions

Authored by dumbbell on Oct 17 2015, 2:54 PM.
Tags
None
Referenced Files
F136488649: D3926.id9469.diff
Tue, Nov 18, 12:45 AM
Unknown Object (File)
Sun, Nov 9, 2:39 AM
Unknown Object (File)
Wed, Nov 5, 9:32 AM
Unknown Object (File)
Thu, Oct 30, 7:48 PM
Unknown Object (File)
Sat, Oct 25, 2:30 PM
Unknown Object (File)
Oct 18 2025, 10:12 AM
Unknown Object (File)
Oct 15 2025, 10:29 PM
Unknown Object (File)
Oct 10 2025, 1:14 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
kib
jhb
imp
Commits
rS294490: iicbus: Use device_delete_children() instead of explicit child removal
rS289657: iicbus: Use device_delete_children() instead of explicit child removal
Summary

If the bus is detached and deleted by a call to device_delete_child() or device_delete_children() on a device higher in the tree, I²C children were already detached and deleted. So the device_t pointer stored in sc points to freed memory: we must not try to delete it again.

The same change is applied to my i915 WIP branch to the i915 driver. This fixes a general protection fault users reported.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 796
Build 796: arc lint + arc unit

Event Timeline

dumbbell updated this revision to Diff 9469.Oct 17 2015, 2:54 PM
dumbbell retitled this revision from to iicbus: Use device_delete_children() instead of explicit child removal If the bus is detached and deleted by a call to device_delete_child() or device_delete_children() on a device higher in the tree, I²C children were already detached and....
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: jhb, kib.
Herald added a subscriber: imp. · View Herald TranscriptOct 17 2015, 2:54 PM
dumbbell updated this object.Oct 17 2015, 2:56 PM
dumbbell retitled this revision from iicbus: Use device_delete_children() instead of explicit child removal If the bus is detached and deleted by a call to device_delete_child() or device_delete_children() on a device higher in the tree, I²C children were already detached and... to iicbus: Use device_delete_children() instead of explicit child removal.
emaste added a subscriber: emaste.Oct 19 2015, 4:23 PM
jhb accepted this revision.Oct 19 2015, 9:29 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2015, 9:29 PM
imp accepted this revision.Oct 19 2015, 11:16 PM
imp added a reviewer: imp.

I like it.

sys/dev/iicbus/iicbus.c
43

Since the only changes to this file are white space, it might be better to do that as a separate commit.

emaste added inline comments.Oct 20 2015, 1:20 AM
sys/dev/iicbus/iicbus.c
43

Agreed

dumbbell added inline comments.Oct 20 2015, 7:12 AM
sys/dev/iicbus/iicbus.c
43

I planned to commit whitespace changes in a separate commit already, even for the other files.

Closed by commit rS289657: iicbus: Use device_delete_children() instead of explicit child removal (authored by dumbbell). · Explain WhyOct 20 2015, 7:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
iicbus/
15 lines
9 lines
1 line
6 lines

Diff 9469

View Options

sys/dev/iicbus/iicbb.c

Loading...
View Options

sys/dev/iicbus/iicbus.c

Loading...
View Options

sys/dev/iicbus/iicoc.c

Loading...
View Options

sys/dev/iicbus/iicsmb.c

Loading...