Paths

Table of Contentst

Differential D31496

ar: diff reduction against ELF Tool Chain
ClosedPublic
Actions

Authored by emaste on Aug 10 2021, 11:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 21, 6:08 PM

	Unknown Object (File)
	Thu, Aug 20, 2:48 PM

	Unknown Object (File)
	Wed, Aug 19, 7:54 PM

	Unknown Object (File)
	Tue, Aug 18, 10:12 PM

	Unknown Object (File)
	Mon, Aug 17, 8:15 AM

	Unknown Object (File)
	Sun, Aug 16, 11:31 AM

	Unknown Object (File)
	Sun, Aug 16, 1:41 AM

	Unknown Object (File)
	Sat, Aug 15, 7:08 AM

Subscribers

Details

Reviewers

Commits

rG6367fd2ccea3: ar: diff reduction against ELF Tool Chain
rGd8ffb451194e: ar: diff reduction against ELF Tool Chain
rG57aaefdceccd: ar: diff reduction against ELF Tool Chain
rGd20e9e02db3d: ar: diff reduction against ELF Tool Chain

Summary

Remove ar_mode_* wrappers and call ar_read_archive / ar_write_archive
directly.

Obtained from:  ELF Tool Chain
Sponsored by:   The FreeBSD Foundation

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Aug 10 2021, 11:33 PM

emaste created this revision.

I think we can drop some sysexits.h includes too?

usr.bin/ar/read.c
67–69	Assertion here too.
usr.bin/ar/write.c
69–70	Should be dropped I guess.
351–354	Upstream ar has an assertion about allowed values for `type` which I think would be worth having.

Updates from mark, rebase

markj accepted this revision.Aug 11 2021, 5:31 PM

This revision is now accepted and ready to land.Aug 11 2021, 5:31 PM

Closed by commit rGd20e9e02db3d: ar: diff reduction against ELF Tool Chain (authored by emaste). · Explain WhyAug 11 2021, 11:13 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGd20e9e02db3d: ar: diff reduction against ELF Tool Chain.

emaste added a reverting change: rGc5bf58add0d5: Revert "ar: diff reduction against ELF Tool Chain".Aug 12 2021, 6:27 PM

emaste mentioned this in rG086f09087713: ar: diff reduction against ELF Tool Chain.Aug 13 2021, 2:40 PM

Correct ranlib breakage reported by @cy

emaste added inline comments.Aug 13 2021, 3:12 PM

usr.bin/ar/ar.c
154	This was the mistake - I had `ar_read_archive(bsdar, 's')` here previously.

markj accepted this revision.Aug 13 2021, 3:14 PM

This revision is now accepted and ready to land.Aug 13 2021, 3:14 PM

Closed by commit rG57aaefdceccd: ar: diff reduction against ELF Tool Chain (authored by emaste). · Explain WhyAug 13 2021, 3:18 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG57aaefdceccd: ar: diff reduction against ELF Tool Chain.

emaste added a commit: rGd8ffb451194e: ar: diff reduction against ELF Tool Chain.Feb 9 2022, 3:26 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 9 2022, 3:26 PM

emaste added a commit: rG6367fd2ccea3: ar: diff reduction against ELF Tool Chain.Feb 9 2022, 4:38 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

ar/

14 lines

14 lines

27 lines

30 lines

51 lines

Diff 93649

usr.bin/ar/acpyacc.y

Loading...

usr.bin/ar/ar.h

Loading...

usr.bin/ar/ar.c

Loading...

usr.bin/ar/read.c

Loading...

usr.bin/ar/write.c

Loading...