Page MenuHomeFreeBSD
Differential D3875

Remove cookie for test target (was: add support for `retest' target)
ClosedPublic
Actions

Authored by AMDmi3 on Oct 13 2015, 12:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 28, 10:32 AM
Unknown Object (File)
Tue, Sep 22, 12:37 AM
Unknown Object (File)
Sun, Sep 6, 10:29 PM
Unknown Object (File)
Sun, Sep 6, 5:49 PM
Unknown Object (File)
Sun, Sep 6, 12:31 PM
Unknown Object (File)
Sun, Sep 6, 9:52 AM
Unknown Object (File)
Sep 3 2026, 6:24 AM
Unknown Object (File)
Sep 3 2026, 4:39 AM
View All Files
Subscribers
bapt
mat

Details

Reviewers
mat
Group Reviewers
portmgr
Commits
rP401117: Don't use cookie for test target

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 751
Build 751: arc lint + arc unit

Event Timeline

AMDmi3 updated this revision to Diff 9341.Oct 13 2015, 12:07 AM
AMDmi3 retitled this revision from to Add support for `retest' target.
AMDmi3 updated this object.
AMDmi3 edited the test plan for this revision. (Show Details)
Herald added a reviewer: portmgr. · View Herald TranscriptOct 13 2015, 12:07 AM
bapt added a subscriber: bapt.Nov 9 2015, 2:34 PM

I think we could just remove the TEST_COOKIE for make test so one can rerun the test target as many time as he wants

mat added a subscriber: mat.Nov 9 2015, 2:37 PM

Mmmm, I'm not sure this is the right way to go. There is no reason for the test target to have a cookie in the first place, nothing depends on test.

AMDmi3 added a comment.Nov 9 2015, 2:47 PM

Hmm, removing the cookie makes sense.

AMDmi3 added a comment.Nov 9 2015, 2:58 PM

OTOH package, though nothing depends on it, has cookie as well. And it also makes sense to automatically not run a target multiple times (and run it multiple times explicitly through retest)

AMDmi3 added a comment.Nov 9 2015, 3:01 PM

Well, I have patches for both :)

bapt added a comment.Nov 9 2015, 3:01 PM

It is not the same, package produces something. Actually use the produced package as a cookie but that won't fit with subpackages.

AMDmi3 updated this revision to Diff 10068.Nov 9 2015, 3:16 PM
AMDmi3 edited edge metadata.

Remove cookie for test target instead

Herald edited edge metadata. · View Herald TranscriptNov 9 2015, 3:16 PM
mat accepted this revision.Nov 9 2015, 3:32 PM
mat added a reviewer: mat.
This revision is now accepted and ready to land.Nov 9 2015, 3:32 PM
Closed by commit rP401117: Don't use cookie for test target (authored by AMDmi3). · Explain WhyNov 9 2015, 5:32 PM
This revision was automatically updated to reflect the committed changes.
AMDmi3 mentioned this in rP401117: Don't use cookie for test target.
AMDmi3 retitled this revision from Add support for `retest' target to Remove cookie for test target (was: add support for `retest' target).Nov 9 2015, 5:32 PM
AMDmi3 edited edge metadata.
danfe mentioned this in D4116: Format IGNORE message to fit standard terminal width.Nov 19 2015, 11:54 AM

Revision Contents
Changeset List

PathSize
Mk/
13 lines

Diff 9341

View Options

Mk/bsd.port.mk

Loading...