Page MenuHomeFreeBSD

Format IGNORE message to fit standard terminal width
ClosedPublic

Authored by danfe on Nov 10 2015, 7:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 10:26 PM
Unknown Object (File)
Sat, Sep 5, 1:51 PM
Unknown Object (File)
Sat, Sep 5, 11:43 AM
Unknown Object (File)
Thu, Sep 3, 5:54 PM
Unknown Object (File)
Thu, Sep 3, 2:51 PM
Unknown Object (File)
Thu, Sep 3, 1:11 PM
Unknown Object (File)
Sep 1 2026, 2:18 PM
Unknown Object (File)
Sep 1 2026, 1:05 PM
Subscribers

Details

Reviewers
bapt
Group Reviewers
portmgr
Summary

Currently, when bsd.port.mk outputs a message addressed to a user, it would typically pipe it through ${FMT} 75 79 command to ensure that if it gets overly long, it would be wrapped nicely.

There is one case where this is not being done: when outputting IGNORE message, which can become very long in e.g. ONLY_FOR_ARCHS_REASON case. This small patch fixes this, and a minor style bug as well (missing section number in sed(1) reference in comment).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

danfe retitled this revision from to Format IGNORE message to fit standard terminal width.
danfe updated this object.
danfe edited the test plan for this revision. (Show Details)
danfe added a reviewer: portmgr.
danfe set the repository for this revision to rP FreeBSD ports repository.
bapt added a reviewer: bapt.
This revision is now accepted and ready to land.Nov 18 2015, 8:20 AM

Closed by commit rP401851 (authored by @danfe). Not sure why it was not closed automatically.

In D4116#88351, @danfe wrote:

Closed by commit rP401851 (authored by @danfe). Not sure why it was not closed automatically.

Because:

  1. the differential revision was not the last (like it is in the commit template)
  2. because you did not put the full url (like it is in the commit template)

First reason could be it, yes; as for the full URL — I've checked some other differentials which apparently were auto-closed correctly (e.g. D3875) and also people on IRC had mentioned that support for short references was added recently. (Certainly, I've asked if full URL is required or not.)

In D4116#88671, @danfe wrote:

First reason could be it, yes; as for the full URL — I've checked some other differentials which apparently were auto-closed correctly (e.g. D3875) and also people on IRC had mentioned that support for short references was added recently. (Certainly, I've asked if full URL is required or not.)

The first reason is it. Now, if you could also respect our documented way of doing it and put the full url, it would be appreciated.

Sorry Mathieu, but I'd put it the other way around: if you guys could update the "documented way" so it does not suffer from stupidity of including full URL now that short references are correctly parsed, it would be appreciated.