Differential D31425

Some clarifications for fork(2) and _Exit(3) man pages
ClosedPublic
Actions

Authored by kib on Aug 5 2021, 4:08 PM.

Tags

None

Referenced Files

	F166476924: D31425.id93333.diff
	Thu, Aug 13, 7:11 PM

	F166471322: D31425.id93346.diff
	Thu, Aug 13, 6:35 PM

	F166316272: D31425.id93415.diff
	Wed, Aug 12, 8:55 PM

	Unknown Object (File)
	Wed, Aug 12, 4:35 PM

	Unknown Object (File)
	Tue, Aug 11, 11:21 PM

	Unknown Object (File)
	Tue, Aug 11, 9:23 PM

	Unknown Object (File)
	Tue, Aug 11, 4:38 PM

	Unknown Object (File)
	Mon, Aug 10, 12:41 PM

Subscribers

None

Details

Reviewers

emaste
markj

Commits

rGee62fb2e1e14: _Exit(3): document implementation
rG2a51e8823a60: fork(2): comment about doubtful use of stdio and exit(3) in example

Summary

fork(2): comment about doubtful use of stdio and exit(3) in example
Add fflush(stdout) as the common idiom. Explain the need to use exit() but advise against it.

_Exit(3): document implementation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib requested review of this revision.Aug 5 2021, 4:08 PM

kib created this revision.

emaste added inline comments.Aug 6 2021, 5:30 PM

lib/libc/sys/fork.2
178	Maybe s/at least/and other possible issues/ or similar, if I understand correctly.

reformulate 'at least'.

markj added inline comments.Aug 6 2021, 7:35 PM

lib/libc/stdlib/exit.3
71–72	I do not understand what this is referring to: tmpfile() unlinks the newly created file before returning.
84	Assuming this refers to tmpfile(3), I do not see why.

Remove references to tmpfile, add notion about destructors registered with __cxa_atexit(3)

markj accepted this revision.Aug 8 2021, 4:31 PM

This revision is now accepted and ready to land.Aug 8 2021, 4:31 PM

emaste accepted this revision.Aug 8 2021, 5:10 PM

Closed by commit rG2a51e8823a60: fork(2): comment about doubtful use of stdio and exit(3) in example (authored by kib). · Explain WhyAug 8 2021, 7:51 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG2a51e8823a60: fork(2): comment about doubtful use of stdio and exit(3) in example.

kib added a commit: rGee62fb2e1e14: _Exit(3): document implementation.

0mp mentioned this in D29880: fork.2: Make the example more robust.Aug 10 2021, 1:43 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdlib/

20 lines

sys/

19 lines

Diff 93346

lib/libc/stdlib/exit.3

Loading...

lib/libc/sys/fork.2

Loading...