xen/grant_table: cleanup max_nr_grant_frames()
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Apr 19 2021, 5:46 PM.

Details

Reviewers

royger
mhorne
julien_xen.org

Commits

rG7de88bb4a2e8: xen/grant_table: cleanup max_nr_grant_frames()

Summary

This is no more or less than returning the smaller of two values. Since
this is what min() does, use that to shrink max_nr_grant_frames() down
to the single line.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ehem_freebsd_m5p.com created this revision.Apr 19 2021, 5:46 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 19 2021, 5:46 PM

ehem_freebsd_m5p.com requested review of this revision.Apr 19 2021, 5:46 PM

Harbormaster completed remote builds in B38691: Diff 87722.Apr 19 2021, 5:46 PM

Looks fine to me. I was wondering if __max_nr_grant_frames() would be evaluated twice, but it seems not as min() is a static inline function, unlike the macro MIN().

This revision is now accepted and ready to land.Apr 24 2021, 6:15 PM

Closed by commit rG7de88bb4a2e8: xen/grant_table: cleanup max_nr_grant_frames() (authored by ehem_freebsd_m5p.com, committed by royger). · Explain WhyJul 28 2021, 3:30 PM

This revision was automatically updated to reflect the committed changes.

royger added a commit: rG7de88bb4a2e8: xen/grant_table: cleanup max_nr_grant_frames().