As the Processor Version Register (PVR) is a 32-bit PowerPC
register, change mfpvr() return type to match it and avoid
type casts on its callers.
Suggested by: jhibbits
Details
Details
- Reviewers
jhibbits imp gnn - Commits
- rG7844e5a4fc0a: powerpc: change mfpvr return type to uint32_t
Tested on POWER9 VM and build tested on powerpc (32-bit).
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 40715 Build 37604: arc lint + arc unit
Event Timeline
Comment Actions
minor quibble, but likely not worth addressing.
| sys/dev/hwpmc/hwpmc_powerpc.c | ||
|---|---|---|
| 607 | mfpvr() doesn't return an int now, but a uint32_t which can be either an int or a long. so there's still a mismatch here, just not one the compiler warns about. In the past, this would be a sure way to get a mismatch between 32-bit and 64-bit compiles, but it seems we've moved to always defining uint32_t as an unsigned int. At least the 'x' format is unsigned... | |