Page MenuHomeFreeBSD

powerpc: change mfpvr return type to uint32_t

Authored by luporl on Jul 28 2021, 12:41 PM.
Referenced Files
Unknown Object (File)
Fri, Sep 29, 4:07 AM
Unknown Object (File)
Thu, Sep 28, 8:44 PM
Unknown Object (File)
Tue, Sep 12, 11:33 AM
Unknown Object (File)
Aug 8 2023, 4:07 AM
Unknown Object (File)
Jun 19 2023, 8:35 PM
Unknown Object (File)
Jun 4 2023, 12:58 PM
Unknown Object (File)
Mar 6 2023, 5:02 PM
Unknown Object (File)
Feb 25 2023, 4:36 PM



As the Processor Version Register (PVR) is a 32-bit PowerPC
register, change mfpvr() return type to match it and avoid
type casts on its callers.

Suggested by: jhibbits

Test Plan

Tested on POWER9 VM and build tested on powerpc (32-bit).

Diff Detail

rS FreeBSD src repository - subversion
Lint Passed
No Test Coverage
Build Status
Buildable 40715
Build 37604: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 28 2021, 2:21 PM

minor quibble, but likely not worth addressing.


mfpvr() doesn't return an int now, but a uint32_t which can be either an int or a long. so there's still a mismatch here, just not one the compiler warns about. In the past, this would be a sure way to get a mismatch between 32-bit and 64-bit compiles, but it seems we've moved to always defining uint32_t as an unsigned int. At least the 'x' format is unsigned...

This revision was automatically updated to reflect the committed changes.