Add the 4 ChromeOS GPT partition types to gpart
ClosedPublic
Actions

Authored by allanjude on Oct 8 2015, 5:25 AM.

Details

Reviewers

grehan
marcel
bapt

Commits

rS292788: Add some additional GPT partition types

Summary

While here, also add OpenBSD, and 2 new Microsoft partition types

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 711
Build 711: arc lint + arc unit

Event Timeline

allanjude updated this revision to Diff 9230.Oct 8 2015, 5:25 AM

allanjude retitled this revision from to Add the 4 ChromeOS GPT partition types to gpart While here, also add OpenBSD, and 2 new Microsoft partition types.

allanjude updated this object.

allanjude edited the test plan for this revision. (Show Details)

allanjude added reviewers: marcel, bapt, grehan.

Herald added a subscriber: imp. · View Herald TranscriptOct 8 2015, 5:25 AM

IIRC, aliases must be sorted so that the binary search works. ms-recovery before ms-reserved, please.
I see we disordered ntfs before netbsd-* as well, so we have a pre-existing bug if the binary search still holds.

In D3841#79411, @marcel wrote:

IIRC, aliases must be sorted so that the binary search works. ms-recovery before ms-reserved, please.
I see we disordered ntfs before netbsd-* as well, so we have a pre-existing bug if the binary search still holds.

Is it a problem to re-order the enum?

Ordered the partition types alphabetically

I double-checked the code and there's actually no binary search logic. It's all linear. Technically speaking, the reordering was not necessary, but I really appreciate the effort. It's a lot easier now to implement a binary search for cases where the linear search gets too time consuming.

Thanks!

This revision is now accepted and ready to land.Nov 3 2015, 7:26 PM

Closed by commit rS292788: Add some additional GPT partition types (authored by allanjude). · Explain WhyDec 27 2015, 6:12 PM

This revision was automatically updated to reflect the committed changes.