Differential D30981

LinuxKPI: add module_pci_driver() and pci_alloc_irq_vectors()
ClosedPublic
Actions

Authored by bz on Jul 1 2021, 1:35 PM.

Details

Reviewers

• hselasky

Group Reviewers

linuxkpi

Commits

rG366d68f28379: LinuxKPI: add module_pci_driver() and pci_alloc_irq_vectors()

Summary

Add the two new functions needed by rtw88 to register the driver and
handle the module bits as well as a version of pci_alloc_irq_vectors()
for what is needed.

MFC after: 10 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40213
Build 37102: arc lint + arc unit

Event Timeline

bz created this revision.Jul 1 2021, 1:35 PM

Herald added a subscriber: emaste. · View Herald TranscriptJul 1 2021, 1:35 PM

bz requested review of this revision.Jul 1 2021, 1:35 PM

Harbormaster completed remote builds in B40213: Diff 91615.Jul 1 2021, 1:35 PM

• hselasky added a subscriber: • hselasky.Jul 1 2021, 3:37 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/pci.h
839	What about MSIX IRQ's ? Can you add a test for that aswell?
845	I think this comment can be removed. No need to allocate.

bz added inline comments.Jul 1 2021, 11:49 PM

sys/compat/linuxkpi/common/include/linux/pci.h
839	I can put a similar block; what's the #define? PCI_IRQ_MSIX? I don't have a driver using that.

• hselasky added inline comments.Jul 2 2021, 8:07 AM

sys/compat/linuxkpi/common/include/linux/pci.h
839	Just define it and add relevant calls for pci_enable_msix(). Should be fairly trivial. include/linux/pci.h:#define PCI_IRQ_MSIX (1 << 2) /* Allow MSI-X interrupts */