Page MenuHomeFreeBSD
Differential D30953

ofw_pci: Fix probing
ClosedPublic
Actions

Authored by kd on Jun 30 2021, 10:01 AM.
Tags
None
Referenced Files
F137797315: D30953.diff
Tue, Nov 25, 9:55 PM
Unknown Object (File)
Sat, Nov 15, 9:15 PM
Unknown Object (File)
Sun, Nov 9, 11:53 AM
Unknown Object (File)
Sat, Nov 1, 2:30 PM
Unknown Object (File)
Oct 12 2025, 8:54 AM
Unknown Object (File)
Sep 30 2025, 2:31 AM
Unknown Object (File)
Sep 20 2025, 2:55 PM
Unknown Object (File)
Sep 19 2025, 10:36 PM
View All Files
Subscribers
None

Details

Reviewers
mw
andrew
mmel
nwhitehorn
Commits
rG94287656264f: ofw_pci: fix probing for non-DT cases
Summary

phandle_t is a uint32_t type, <= 0 comparison doesn't work with it as intended.
This caused the ofw_pci code to attach to PCI bus on ACPI based systems.
Since 3eae4e106ac7 ofw subsystem can only return -1 for invalid nodes.
Use that.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kd requested review of this revision.Jun 30 2021, 10:01 AM
kd created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2021, 6:36 PM
Closed by commit rG94287656264f: ofw_pci: fix probing for non-DT cases (authored by kd, committed by mw). · Explain Why
This revision was automatically updated to reflect the committed changes.
mw added a commit: rG94287656264f: ofw_pci: fix probing for non-DT cases.

Revision Contents
Changeset List

PathSize
sys/
dev/
ofw/
2 lines

Diff 91555

View Options

sys/dev/ofw/ofw_pci.c

Loading...