Differential D30944

pf: Reduce the data returned in DIOCGETSTATESNV
ClosedPublic
Actions

Authored by kp on Jun 29 2021, 7:38 PM.

Tags

None

Referenced Files

	F140087139: D30944.id91521.diff
	Sat, Dec 20, 1:43 AM

	Unknown Object (File)
	Thu, Nov 27, 7:52 AM

	Unknown Object (File)
	Tue, Nov 25, 11:48 AM

	Unknown Object (File)
	Nov 20 2025, 8:30 AM

	Unknown Object (File)
	Nov 20 2025, 8:27 AM

	Unknown Object (File)
	Nov 18 2025, 10:27 AM

	Unknown Object (File)
	Nov 18 2025, 8:48 AM

	Unknown Object (File)
	Nov 17 2025, 8:08 PM

Subscribers

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG63a8dc255208: pf: Reduce the data returned in DIOCGETSTATESNV
rG9e5d987058fe: pf: Reduce the data returned in DIOCGETSTATESNV
rG34285eefddc9: pf: Reduce the data returned in DIOCGETSTATESNV

Summary

This call is particularly slow due to the large amount of data it
returns. Remove all fields pfctl does not use. There is no functional
impact to pfctl, but it somewhat speeds up the call.

It might affect other (i.e. non-FreeBSD) code that uses the new
interface, but this call is very new, so there's unlikely to be any. No
releases contained the previous version, so we choose to live with the
ABI modification.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40171
Build 37060: arc lint + arc unit

Event Timeline

kp created this revision.Jun 29 2021, 7:38 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptJun 29 2021, 7:38 PM

kp requested review of this revision.Jun 29 2021, 7:38 PM

Harbormaster completed remote builds in B40171: Diff 91521.Jun 29 2021, 7:38 PM

kp added a parent revision: D30943: pf tests: Stress state retrieval.Jun 29 2021, 7:38 PM

kp added a child revision: D30945: libpfctl: improve DIOCGETSTATESNV size estimation.

Please MFC this to any version containing the "old" ABI, so that no intermediate versions enter the external visible trains.

This revision is now accepted and ready to land.Jun 30 2021, 3:21 PM

Closed by commit rG34285eefddc9: pf: Reduce the data returned in DIOCGETSTATESNV (authored by kp). · Explain WhyJul 2 2021, 1:50 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG34285eefddc9: pf: Reduce the data returned in DIOCGETSTATESNV.

kp added a commit: rG9e5d987058fe: pf: Reduce the data returned in DIOCGETSTATESNV.Jul 9 2021, 1:24 PM

kp added a commit: rG63a8dc255208: pf: Reduce the data returned in DIOCGETSTATESNV.

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

12 lines

22 lines

sys/

netpfil/

pf/

34 lines

Diff 91521

lib/libpfctl/libpfctl.h

Loading...

lib/libpfctl/libpfctl.c

Loading...

sys/netpfil/pf/pf_nv.c

Loading...