Differential D30788

emulators/linux_base-ubuntu: Add port
Needs ReviewPublic
Actions

Authored by trasz on Jun 16 2021, 2:22 PM.

Details

Reviewers

freebsd_darkain.com

Group Reviewers

Linux Emulation

Summary

This is somewhat similar to emulators/linux_base-c7, except:

It's from Ubuntu Focal
It's one port instead of many small ones
It installs under /usr/local/compat/linux, not /compat/linux

Obviously it needs some adjusting for various mounts, changing
the compat.linux.emul_path etc; I'll do that later on.

Note that this is not a proper chroot or jail. Everything
normally configured by the package triggers is missing, because
we don't execute them, only unpack. I think this shouldn't cause
any problems, but if it does, it's to be addresssed at install
time.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 39931
Build 36820: arc lint + arc unit

Event Timeline

trasz created this revision.Jun 16 2021, 2:22 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 16 2021, 2:22 PM

trasz requested review of this revision.Jun 16 2021, 2:22 PM

Harbormaster completed remote builds in B39931: Diff 90961.Jun 16 2021, 2:22 PM

Note that this is mostly a prototype at this stage; still, any feedback is welcome.

jrtc27 added a subscriber: jrtc27.Jun 16 2021, 3:27 PM

jrtc27 added inline comments.

emulators/linux_base-ubuntu/Makefile
11	amd64 (and i386) are in archive.ubuntu.com/ubuntu

trasz added inline comments.Jun 16 2021, 4:35 PM

emulators/linux_base-ubuntu/Makefile
11	Thanks! Do you know if it's safe to assume that the package set, ie the list of packages, their versions, and the package file names (apart from the "arm64" part) will stay the same between arm64 and amd64?

jrtc27 added inline comments.Jun 16 2021, 4:38 PM

emulators/linux_base-ubuntu/Makefile
11	In Ubuntu the versions should be for releases. In Debian the versions almost are in releases, except for when there are binNMUs for rebuilds and you can get skew, but Ubuntu doesn't do binNMUs, it just does no-change source uploads so everything's always in sync. For the list of essential and required packages I expect they're the same between aarch64 and amd64, though it'd be worth verifying.

trasz added a reviewer: freebsd_darkain.com.Jun 17 2021, 3:49 PM

Lots of changes.

Herald added subscribers: emaste, andrew. · View Herald TranscriptJun 17 2021, 6:01 PM

Harbormaster completed remote builds in B39957: Diff 91025.Jun 17 2021, 6:01 PM

jrtc27 added inline comments.Jun 17 2021, 6:41 PM

emulators/linux_base-ubuntu/Makefile
4	Hmm, including GUI stuff seems like it'd be more likely to diverge between architectures. gnome-software is also a strange choice?
399	Other arches?
402	You probably want to error if the target doesn't exist, otherwise things will silently break in future versions

trasz added inline comments.Jun 18 2021, 9:04 AM

emulators/linux_base-ubuntu/Makefile
4	I'm afraid we really need the GUI part; most of the ports that would make use of this are graphical apps. As for "gnome-software" - I'm open to suggestions. Tbh I've already had to add some libraries by hand, and remove a few others.
399	Neither i386 nor aarch64 seem to require this kind of fix.
402	Shouldn't it error out as it is, given it's a makefile?