toe: Read-lock the inp in toe_4tuple_check().
ClosedPublic
Actions

Authored by jhb on Jun 16 2021, 12:27 AM.

Tags

None

Referenced Files

	F164725156: D30782.id90939.diff
	Mon, Aug 3, 9:00 AM

	F164665499: D30782.id91248.diff
	Mon, Aug 3, 1:41 AM

	Unknown Object (File)
	Sun, Aug 2, 8:15 AM

	Unknown Object (File)
	Sun, Aug 2, 2:32 AM

	Unknown Object (File)
	Thu, Jul 30, 2:19 PM

	Unknown Object (File)
	Wed, Jul 22, 10:37 AM

	Unknown Object (File)
	Tue, Jul 21, 3:36 AM

	Unknown Object (File)
	Jun 25 2026, 11:28 PM

View All Files

Subscribers

imp

melifaro

Details

Reviewers

glebius
np

Commits

rGa7f6c6fd94d6: toe: Read-lock the inp in toe_4tuple_check().

Summary

tcp_twcheck now expects a read lock on the inp for the SYN case
instead of a write lock.

Fixes: 1db08fbe3ffa tcp_input: always request read-locking of PCB for any pure SYN segment.
Sponsored by: Chelsio Communications

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39926
Build 36815: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 16 2021, 12:27 AM

Herald added subscribers: melifaro, imp. · View Herald TranscriptJun 16 2021, 12:27 AM

jhb requested review of this revision.Jun 16 2021, 12:27 AM

Harbormaster completed remote builds in B39926: Diff 90939.Jun 16 2021, 12:27 AM

Ping.

np accepted this revision.Jun 22 2021, 11:18 PM

This revision is now accepted and ready to land.Jun 22 2021, 11:18 PM

Closed by commit rGa7f6c6fd94d6: toe: Read-lock the inp in toe_4tuple_check(). (authored by jhb). · Explain WhyJun 22 2021, 11:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa7f6c6fd94d6: toe: Read-lock the inp in toe_4tuple_check()..

Revision Contents
Changeset List

Path

Size

sys/

netinet/

toecore.c

8 lines

Diff 90939

View Options

toe: Read-lock the inp in toe_4tuple_check().ClosedPublicActions