Page MenuHomeFreeBSD
Differential D30568

libalias: Restructure - Common search terms
ClosedPublic
Actions

Authored by donner on May 31 2021, 1:52 PM.
Tags
None
Referenced Files
F114689527: D30568.id90170.diff
Tue, Apr 15, 11:58 AM
F114687906: D30568.id90240.diff
Tue, Apr 15, 11:23 AM
F114666391: D30568.id91104.diff
Tue, Apr 15, 3:29 AM
Unknown Object (File)
Mar 16 2025, 11:47 AM
Unknown Object (File)
Mar 12 2025, 1:41 PM
Unknown Object (File)
Mar 9 2025, 8:36 PM
Unknown Object (File)
Mar 8 2025, 6:45 AM
Unknown Object (File)
Mar 4 2025, 6:57 PM
View All Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rGe0a40dc22771: libalias: Restructure
rG78d515b2225e: libalias: Restructure
rGd41044ddfdbc: libalias: Restructure - Common search terms
Summary

Factor out the common Out and In filter
Slightly better performance due to eager skip of search loop

Test Plan

Run testsuite.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39882
Build 36771: arc lint + arc unit

Event Timeline

donner created this revision.May 31 2021, 1:52 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 31 2021, 1:52 PM
donner requested review of this revision.May 31 2021, 1:52 PM
Harbormaster completed remote builds in B39585: Diff 90170.May 31 2021, 1:52 PM
donner added a parent revision: D30566: libalias: Promote per instance global variable timeStamp.May 31 2021, 1:52 PM
donner added a reviewer: network.
donner added a child revision: D30569: libalias: Restructure - Separate fully qualified search.May 31 2021, 2:15 PM
donner added a child revision: D30572: libalias: Restructure - Outgoing search.May 31 2021, 2:54 PM
donner updated this revision to Diff 90240.Jun 1 2021, 9:25 AM

Rebase

Harbormaster completed remote builds in B39624: Diff 90240.Jun 1 2021, 9:25 AM
donner removed a parent revision: D30566: libalias: Promote per instance global variable timeStamp.Jun 1 2021, 9:50 AM
donner updated this revision to Diff 90833.Jun 13 2021, 8:48 PM

rebase

Harbormaster completed remote builds in B39882: Diff 90833.Jun 13 2021, 8:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2021, 5:05 PM
Closed by commit rGd41044ddfdbc: libalias: Restructure - Common search terms (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rGd41044ddfdbc: libalias: Restructure - Common search terms.
donner added a commit: rG78d515b2225e: libalias: Restructure.Jul 6 2021, 6:57 AM
donner added a commit: rGe0a40dc22771: libalias: Restructure.Jul 6 2021, 7:12 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
48 lines

Diff 90833

View Options

sys/netinet/libalias/alias_db.c

Loading...