bectl(8): don't allow creation of boot environments with spaces
ClosedPublic
Actions

Authored by rew on May 10 2021, 8:01 PM.

Details

Reviewers

allanjude
kevans

Commits

rGe1dfdff10967: bectl(8): don't allow creation of boot environments with spaces
rG01cf73198d1e: bectl(8): don't allow creation of boot environments with spaces
rG0e6549c87450: bectl(8): don't allow creation of boot environments with spaces

Summary

Boot environment datasets that contain spaces are not bootable.

When a user attempts to create a boot environment with a space, abort
the creation and print an error message.

PR: 254441

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.May 10 2021, 8:01 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2021, 8:01 PM

rew requested review of this revision.May 10 2021, 8:01 PM

Harbormaster completed remote builds in B39106: Diff 88984.May 10 2021, 8:01 PM

rew added reviewers: allanjude, kevans.May 10 2021, 8:03 PM

If there are other characters that need to be blocked, it might make sense to use strcspn. Although I think in this case, what you have here is fine.

This revision is now accepted and ready to land.Jun 2 2021, 12:24 PM

Closed by commit rG0e6549c87450: bectl(8): don't allow creation of boot environments with spaces (authored by rew). · Explain WhyJun 3 2021, 4:48 PM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rG0e6549c87450: bectl(8): don't allow creation of boot environments with spaces.

rew added a commit: rG01cf73198d1e: bectl(8): don't allow creation of boot environments with spaces.Jun 11 2021, 5:59 PM

rew added a commit: rGe1dfdff10967: bectl(8): don't allow creation of boot environments with spaces.Jun 11 2021, 6:03 PM

Revision Contents
Changeset List

Path

Size

sbin/

bectl/

bectl.c

9 lines

tests/

bectl_test.sh

4 lines

Diff 90366

View Options

sbin/bectl/bectl.c