Page MenuHomeFreeBSD
Differential D30587

libalias: Stats are unsigned
ClosedPublic
Actions

Authored by donner on May 31 2021, 10:10 PM.
Tags
None
Referenced Files
F147693290: D30587.diff
Thu, Mar 12, 11:26 PM
Unknown Object (File)
Thu, Mar 5, 6:16 PM
Unknown Object (File)
Mon, Mar 2, 10:11 AM
Unknown Object (File)
Sat, Feb 28, 10:00 AM
Unknown Object (File)
Sat, Feb 28, 2:43 AM
Unknown Object (File)
Fri, Feb 27, 9:10 PM
Unknown Object (File)
Wed, Feb 25, 1:44 PM
Unknown Object (File)
Tue, Feb 17, 6:43 PM
View All Files
Subscribers
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
network
Commits
rGe3c21cc51bec: libalias: Stats are unsigned
rG69965155a5c2: libalias: Stats are unsigned
rG3fd20a79e7b5: libalias: Stats are unsigned
Summary

Stats counters are used as unsigned valued (i.e. printf("%u")) but are
defined as signed int. This causes trouble later, so fix it early.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39621
Build 36510: arc lint + arc unit

Event Timeline

donner created this revision.May 31 2021, 10:10 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptMay 31 2021, 10:10 PM
donner requested review of this revision.May 31 2021, 10:10 PM
Harbormaster completed remote builds in B39614: Diff 90217.May 31 2021, 10:10 PM
donner added a child revision: D30566: libalias: Promote per instance global variable timeStamp.May 31 2021, 10:13 PM
donner added a reviewer: network.May 31 2021, 10:47 PM
donner updated this revision to Diff 90237.Jun 1 2021, 9:23 AM

Rebased

Harbormaster completed remote builds in B39621: Diff 90237.Jun 1 2021, 9:23 AM
donner updated this revision to Diff 90831.Jun 13 2021, 8:47 PM

Rebase

Harbormaster completed remote builds in B39880: Diff 90831.Jun 13 2021, 8:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 19 2021, 4:22 PM
Closed by commit rG3fd20a79e7b5: libalias: Stats are unsigned (authored by donner). · Explain Why
This revision was automatically updated to reflect the committed changes.
donner added a commit: rG3fd20a79e7b5: libalias: Stats are unsigned.
donner added a commit: rG69965155a5c2: libalias: Stats are unsigned.Jul 6 2021, 6:57 AM
donner added a commit: rGe3c21cc51bec: libalias: Stats are unsigned.Jul 6 2021, 7:12 AM

Revision Contents
Changeset List

PathSize
sys/
netinet/
libalias/
16 lines

Diff 90237

View Options

sys/netinet/libalias/alias_local.h

Loading...