pf: Avoid leaking pad bytes in struct pfr_astats when copying out
ClosedPublic
Actions

Authored by markj on May 31 2021, 6:50 PM.

Details

Reviewers

kp
imp

Commits

rG60a38abb8982: pf: Avoid leaking pad bytes in struct pfr_astats when copying out

Summary

There is padding between pfr_astats.pfras_a and pfras_packets that was
not getting initialized.

Reported by: KMSAN

Test Plan

pf regression tests

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39612
Build 36501: arc lint + arc unit

Event Timeline

markj created this revision.May 31 2021, 6:50 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMay 31 2021, 6:50 PM

markj requested review of this revision.May 31 2021, 6:50 PM

Harbormaster completed remote builds in B39608: Diff 90198.May 31 2021, 6:50 PM

markj edited the test plan for this revision. (Show Details)May 31 2021, 6:50 PM

markj added a reviewer: kp.

imp accepted this revision.May 31 2021, 6:51 PM

This revision is now accepted and ready to land.May 31 2021, 6:51 PM

Zero the correct pointer.

This revision now requires review to proceed.May 31 2021, 8:56 PM

Harbormaster completed remote builds in B39612: Diff 90215.May 31 2021, 8:57 PM

MFC after: ?

This revision is now accepted and ready to land.Jun 1 2021, 7:12 AM

In D30585#686909, @kp wrote:

MFC after: ?

Will MFC after 1 week. (I'm not in the habit of including that in review descriptions, but I should start...)

Closed by commit rG60a38abb8982: pf: Avoid leaking pad bytes in struct pfr_astats when copying out (authored by markj). · Explain WhyJun 1 2021, 11:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG60a38abb8982: pf: Avoid leaking pad bytes in struct pfr_astats when copying out.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_table.c

1 line

Diff 90215

View Options

pf: Avoid leaking pad bytes in struct pfr_astats when copying outClosedPublicActions