Page MenuHomeFreeBSD

pf: Avoid leaking pad bytes in struct pfr_astats when copying out
ClosedPublic

Authored by markj on May 31 2021, 6:50 PM.

Details

Summary

There is padding between pfr_astats.pfras_a and pfras_packets that was
not getting initialized.

Reported by: KMSAN

Test Plan

pf regression tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.May 31 2021, 6:50 PM
markj added a reviewer: kp.
This revision is now accepted and ready to land.May 31 2021, 6:51 PM

Zero the correct pointer.

This revision now requires review to proceed.May 31 2021, 8:56 PM
This revision is now accepted and ready to land.Jun 1 2021, 7:12 AM
In D30585#686909, @kp wrote:

MFC after: ?

Will MFC after 1 week. (I'm not in the habit of including that in review descriptions, but I should start...)