Page MenuHomeFreeBSD
Differential D30585

pf: Avoid leaking pad bytes in struct pfr_astats when copying out
ClosedPublic
Actions

Authored by markj on May 31 2021, 6:50 PM.
Tags
None
Referenced Files
F163250154: D30585.id90215.diff
Tue, Jul 21, 10:21 AM
Unknown Object (File)
Sun, Jul 19, 7:13 PM
Unknown Object (File)
Sat, Jul 18, 3:54 PM
Unknown Object (File)
Sat, Jul 18, 10:07 AM
Unknown Object (File)
Sun, Jul 5, 7:39 AM
Unknown Object (File)
Jun 21 2026, 4:09 AM
Unknown Object (File)
Jun 19 2026, 1:05 AM
Unknown Object (File)
May 13 2026, 1:31 PM
View All Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
kp
imp
Commits
rG60a38abb8982: pf: Avoid leaking pad bytes in struct pfr_astats when copying out
Summary

There is padding between pfr_astats.pfras_a and pfras_packets that was
not getting initialized.

Reported by: KMSAN

Test Plan

pf regression tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39608
Build 36497: arc lint + arc unit

Event Timeline

markj created this revision.May 31 2021, 6:50 PM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptMay 31 2021, 6:50 PM
markj requested review of this revision.May 31 2021, 6:50 PM
Harbormaster completed remote builds in B39608: Diff 90198.May 31 2021, 6:50 PM
markj edited the test plan for this revision. (Show Details)May 31 2021, 6:50 PM
markj added a reviewer: kp.
imp accepted this revision.May 31 2021, 6:51 PM
This revision is now accepted and ready to land.May 31 2021, 6:51 PM
markj updated this revision to Diff 90215.May 31 2021, 8:56 PM

Zero the correct pointer.

This revision now requires review to proceed.May 31 2021, 8:56 PM
Harbormaster completed remote builds in B39612: Diff 90215.May 31 2021, 8:57 PM
kp accepted this revision.Jun 1 2021, 7:12 AM

MFC after: ?

This revision is now accepted and ready to land.Jun 1 2021, 7:12 AM
markj added a comment.Jun 1 2021, 2:57 PM
In D30585#686909, @kp wrote:

MFC after: ?

Will MFC after 1 week. (I'm not in the habit of including that in review descriptions, but I should start...)

Closed by commit rG60a38abb8982: pf: Avoid leaking pad bytes in struct pfr_astats when copying out (authored by markj). · Explain WhyJun 1 2021, 11:52 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG60a38abb8982: pf: Avoid leaking pad bytes in struct pfr_astats when copying out.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
1 line

Diff 90198

View Options

sys/netpfil/pf/pf_table.c

Loading...