libpmc: make libpmc_pmu_utils.c more amenable to porting
ClosedPublic
Actions

Authored by mhorne on May 28 2021, 6:54 PM.

Details

Reviewers

emaste
ray

Group Reviewers

pmc

Commits

rG87c9a2933bdb: libpmc: make libpmc_pmu_utils.c more amenable to porting
rG0024f1aa7720: libpmc: make libpmc_pmu_utils.c more amenable to porting

Summary

The current version has every function stubbed out for !x86. Only two
functions (pmu_alias_get() and pmc_pmu_pmcallocate() are really platform
dependent, so reduce the width of the ifdefs and remove some of the
stubs.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39547
Build 36436: arc lint + arc unit

Event Timeline

mhorne created this revision.May 28 2021, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 28 2021, 6:54 PM

mhorne requested review of this revision.May 28 2021, 6:54 PM

Harbormaster completed remote builds in B39547: Diff 90074.May 28 2021, 6:54 PM

LGTM
Thanks!

This revision is now accepted and ready to land.May 28 2021, 10:31 PM

Closed by commit rG0024f1aa7720: libpmc: make libpmc_pmu_utils.c more amenable to porting (authored by mhorne). · Explain WhyMay 31 2021, 8:41 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG0024f1aa7720: libpmc: make libpmc_pmu_utils.c more amenable to porting.

mhorne added a commit: rG87c9a2933bdb: libpmc: make libpmc_pmu_utils.c more amenable to porting.Jul 29 2021, 3:27 PM

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

libpmc_pmu_util.c

65 lines

Diff 90074

View Options

lib/libpmc/libpmc_pmu_util.c

libpmc: make libpmc_pmu_utils.c more amenable to portingClosedPublicActions