Page MenuHomeFreeBSD

LinuxKPI: add irq_set_affinity_hint()
ClosedPublic

Authored by bz on May 24 2021, 6:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 8:00 PM
Unknown Object (File)
Sun, Jun 9, 11:53 AM
Unknown Object (File)
Mon, May 27, 8:47 AM
Unknown Object (File)
May 2 2024, 1:24 AM
Unknown Object (File)
Apr 24 2024, 9:32 PM
Unknown Object (File)
Feb 7 2024, 1:12 PM
Unknown Object (File)
Jan 28 2024, 7:58 PM
Unknown Object (File)
Dec 22 2023, 11:38 PM

Details

Summary

Add an implementation for irq_set_affinity_hint() to linux/interrupt.h
and include linux/hardirq.h for synchronize_irq() as needed by
wireless drivers.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by:
Differential Revision:

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39416
Build 36305: arc lint + arc unit

Event Timeline

bz requested review of this revision.May 24 2021, 6:28 PM
hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/interrupt.h
202

Synchronize IRQ is already defined here:
sys/compat/linuxkpi/common/include/linux/hardirq.h:#define synchronize_irq(irq) _intr_drain((irq))

Please resolve!

sys/compat/linuxkpi/common/include/linux/interrupt.h
44

This is also defined in irqreturn but differently. Sigh.

202

Seems we can just include linux/hardirq.h here.

Include hardirq.h instead of synchronize_irq().

bz marked an inline comment as done.May 25 2021, 8:25 AM
bz retitled this revision from LinuxKPI: add irq_set_affinity_hint() and synchronize_irq() to LinuxKPI: add irq_set_affinity_hint().May 25 2021, 8:35 AM
bz edited the summary of this revision. (Show Details)

Can you have a look at this updated version as well please?

s/__inline/inline

Else looks good.

This revision is now accepted and ready to land.May 25 2021, 11:30 AM
This revision was automatically updated to reflect the committed changes.